Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redhatsignedrpmcheck: Add remediation hint and URL #1326

Merged
merged 1 commit into from
Jan 17, 2025
Merged

redhatsignedrpmcheck: Add remediation hint and URL #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions repos/system_upgrade/common/actors/redhatsignedrpmcheck/libraries/redhatsignedrpmcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from leapp.libraries.stdlib.config import is_verbose
from leapp.models import InstalledUnsignedRPM

COMMON_REPORT_TAGS = [reporting.Groups.SANITY]


def generate_report(packages):
""" Generate a report if there are unsigned packages installed on the system """
Expand All @@ -16,11 +14,30 @@ def generate_report(packages):
' and may be removed during the upgrade process in case Red Hat-signed'
' packages to be removed during the upgrade depend on them:\n{}'
.format(unsigned_packages_new_line))
hint = (
'The most simple solution that does not require additional knowledge'
' about the upgrade process'
' is the uninstallation of such packages before the upgrade and'
' installing these (or their newer versions compatible with the target'
' system) back after the upgrade. Also you can just try to upgrade the'
' system on a testing machine (or after the full system backup) to see'
' the result.\n'
'However, it is common use case to migrate or upgrade installed third'
' party packages together with the system during the in-place upgrade'
' process. To examine how to customize the process to deal with such'
' packages, follow the documentation in the attached link'
' for more details.'
)
reporting.create_report([
reporting.Title(title),
reporting.Summary(summary),
reporting.Severity(reporting.Severity.HIGH),
reporting.Groups(COMMON_REPORT_TAGS)
reporting.Groups([reporting.Groups.SANITY]),
reporting.Remediation(hint=hint),
reporting.ExternalLink(
url='https://red.ht/customize-rhel-upgrade-actors',
title='Handling the migration of your custom and third-party applications'
)
])

if is_verbose():
Expand Down
Loading