feat: flush oracle cache on reorg #724

[piotr-roslaniec]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.8%. Comparing base (13d7e82) to head (2b2ba67).
Report is 3 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[refcell]

Nice work, nearly there with a few changes

[refcell]

It doesn't look like we're using this, since the FlushableCache trait provides this.

Suggested change

	/// Flushes the cache, removing all entries.
	pub fn flush(&self) {
	self.cache.lock().clear();
	}

[refcell]

We will need to perform a full reset on a reorg and not just a channel flush.
Basically, we need to check inside the else branch below if e matches the ResetError::ReorgDetected(_, _), then flush the caching oracle and resume with sending a reset signal.

e.g.

  } else {
      if matches!(e, ResetError::ReorgDetected(_, _)) {
            self.caching_oracle.as_ref().flush();
      }
      // Reset the pipeline to the initial L2 safe head and L1 origin,
      // and try again.
      self.pipeline
          .signal(
              ResetSignal {
                  l2_safe_head: self.l2_safe_head,
                  l1_origin: self
                      .pipeline
                      .origin()
                      .ok_or_else(|| anyhow!("Missing L1 origin"))?,
                  system_config: Some(system_config),
              }
              .signal(),
          )
          .await?;
  }

[refcell]

Great work @piotr-roslaniec!