-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed irrelevant dependency on package sensors_plus #5040
Conversation
What was the use case for using it (accelerometer, gyroscope, and magnetometer sensors)? @monsieurtanuki @g123k any clue ? |
@teolemon The impact was an animation up to 30 pixels depending on the gyroscope. My guess is that there was something more ambitious, finally discarded, except for this couple of code lines. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5040 +/- ##
==========================================
- Coverage 9.54% 7.75% -1.80%
==========================================
Files 325 366 +41
Lines 16411 18470 +2059
==========================================
- Hits 1567 1432 -135
- Misses 14844 17038 +2194 ☔ View full report in Codecov by Sentry. |
Closing as stale. |
|
||
final double screenWidth; | ||
|
||
@override | ||
State<Background> createState() => _BackgroundState(); | ||
State<_Background> createState() => _BackgroundState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Widget can now become Stateless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, I didn't see your change.
Thanks!
Thank you @g123k for your review! |
What
Fixes bug(s)