Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed irrelevant dependency on package sensors_plus #5040

Merged
merged 17 commits into from
May 30, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • We got pinged for an upgrade of package sensors_plus.
  • We actually have a very very limited usage of this package: only on the very first onboarding page and for a questionable added value.
  • I think we would be better off without this package for the moment, for maintenance reasons.
  • Of course if in the future we have sensible use-cases that would require sensors_plus, we would put it back in our dependencies.

Fixes bug(s)

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner February 5, 2024 08:07
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… dependencies labels Feb 5, 2024
@teolemon
Copy link
Member

teolemon commented Feb 6, 2024

What was the use case for using it (accelerometer, gyroscope, and magnetometer sensors)? @monsieurtanuki @g123k any clue ?

@monsieurtanuki
Copy link
Contributor Author

What was the use case for using it (accelerometer, gyroscope, and magnetometer sensors)? @monsieurtanuki @g123k any clue ?

@teolemon The impact was an animation up to 30 pixels depending on the gyroscope. My guess is that there was something more ambitious, finally discarded, except for this couple of code lines.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 7.75%. Comparing base (4d9c7fc) to head (42cabe4).
Report is 146 commits behind head on develop.

Files Patch % Lines
...oth_app/lib/pages/onboarding/reinvention_page.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5040      +/-   ##
==========================================
- Coverage     9.54%   7.75%   -1.80%     
==========================================
  Files          325     366      +41     
  Lines        16411   18470    +2059     
==========================================
- Hits          1567    1432     -135     
- Misses       14844   17038    +2194     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki monsieurtanuki requested a review from M123-dev March 9, 2024 15:42
@monsieurtanuki
Copy link
Contributor Author

Closing as stale.

@monsieurtanuki monsieurtanuki requested a review from g123k May 28, 2024 11:27

final double screenWidth;

@override
State<Background> createState() => _BackgroundState();
State<_Background> createState() => _BackgroundState();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Widget can now become Stateless

@monsieurtanuki monsieurtanuki requested a review from g123k May 28, 2024 12:15
@monsieurtanuki
Copy link
Contributor Author

image

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, I didn't see your change.
Thanks!

@g123k g123k merged commit c8b72e0 into openfoodfacts:develop May 30, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants