Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-9166 | fix: create common validator to check duplicated IAM role arns for ROSA STS cluster #61

Merged
merged 1 commit into from
Jun 27, 2024
Merged

OCM-9166 | fix: create common validator to check duplicated IAM role arns for ROSA STS cluster #61

merged 1 commit into from
Jun 27, 2024

Conversation

davidleerh
Copy link
Contributor

No description provided.

hunterkepley
hunterkepley reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@hunterkepley hunterkepley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the duplicated string isn't too important, so feel free to ignore

pkg/aws/validations/iam_helpers.go Outdated Show resolved Hide resolved
@marcolan018
Copy link
Contributor

/lgtm

@davidleerh davidleerh merged commit 35b747c into openshift-online:main Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcolan018 marcolan018 marcolan018 left review comments

@hunterkepley hunterkepley hunterkepley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidleerh @marcolan018 @hunterkepley