Webpack 5 upgrade (continued) #35
Conversation
|
|
||
| // Don't mark an import as built in if it is the name of the package itself | ||
| // eg. `events` | ||
| if (builtInNode[packageName]) { |
There was a problem hiding this comment.
@pastelsky this has since changed in webpack. we now set node: false to tell it not to polyfill any builtins. but losing this if concerns me, would you be able to explain what the intention of this whole block was (builtInNode) and if disabling it entirely will suffice?
| }, | ||
| }, | ||
| }), | ||
| '...', | ||
| // @ts-ignore: Appears that the library might have incorrect definitions |
There was a problem hiding this comment.
zoobestik/csso-webpack-plugin#18 will fix this if they publish a new version
| new VueLoaderPlugin(), | ||
| new MiniCssExtractPlugin({ | ||
| // Options similar to the same options in webpackOptions.output | ||
| // both options are optional | ||
| filename: '[name].bundle.css', | ||
| chunkFilename: '[id].bundle.css', | ||
| }), | ||
| ...(debug ? [new WriteFilePlugin()] : []), |
There was a problem hiding this comment.
i don't fully understand what this was doing, another for @pastelsky. it was writing the output to disk during watch mode i guess but to what end? the plugin doesn't support webpack 5 so im wondering/hoping we can drop it
|
@43081j I was working on this in parallel as well. I'm nearly done getting this to work with webpack 5 sans typecheck. We wpuld need to do some performance testing and test functions other than Let me push changes to a next branch tomorrow. |
|
sure, ill pause for now then. let me know if there's anything i've mentioned or referenced here thats still of any help. |
|
@pastelsky DefinitelyTyped/DefinitelyTyped#52044 has merged now so once they publish it, you won't need to cast mini-css-extract-plugin as webpack/webpack#13016 has also been merged so you can import csso plugin has also been published under 2.x beta now which sorts the v5 types |
|
@pastelsky did you ever get anywhere with this? |
|
closing since i guess it was done elsewhere (or if not, this branch is a fossil by now anyway) |
This is continuing where #34 left off as justin didn't have time.
I will try pick it up and see where I get to.
Related:
StatsAssetExport StatsAsset in the types webpack/webpack#13014false, here we have simply setnode: falseto tell webpack not to polyfill anything - this also needs a decisioncc @justinfagnani @sokra