Webpack 5 upgrade (continued) #35
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,11 @@ | ||
| import autoprefixer from 'autoprefixer' | ||
| import MiniCssExtractPlugin from 'mini-css-extract-plugin' | ||
| import CssoWebpackPlugin from 'csso-webpack-plugin' | ||
|
|
||
| const log = require('debug')('bp:webpack') | ||
| import escapeRegex from 'escape-string-regexp' | ||
| import webpack, { Entry } from 'webpack' | ||
| import VueLoaderPlugin from 'vue-loader/dist/plugin' | ||
|
|
||
| import { Externals } from '../common.types' | ||
|
|
||
|
|
@@ -41,30 +37,12 @@ export default function makeWebpackConfig({ | |
|
|
||
| log('external packages %o', externalsRegex) | ||
|
|
||
| return { | ||
| entry: entry, | ||
| mode: 'production', | ||
| // bail: true, | ||
| optimization: { | ||
| chunkIds: 'named', | ||
| runtimeChunk: { name: 'runtime' }, | ||
| minimize: true, | ||
| splitChunks: { | ||
|
|
@@ -78,29 +56,20 @@ export default function makeWebpackConfig({ | |
| }, | ||
| }, | ||
| minimizer: [ | ||
| '...', | ||
| // @ts-ignore: Appears that the library might have incorrect definitions | ||
|
There was a problem hiding this comment. zoobestik/csso-webpack-plugin#18 will fix this if they publish a new version |
||
| new CssoWebpackPlugin({ restructure: false }), | ||
| ], | ||
| }, | ||
| plugins: [ | ||
| new webpack.IgnorePlugin({ resourceRegExp: /^electron$/ }), | ||
| new VueLoaderPlugin(), | ||
| new MiniCssExtractPlugin({ | ||
| // Options similar to the same options in webpackOptions.output | ||
| // both options are optional | ||
| filename: '[name].bundle.css', | ||
| chunkFilename: '[id].bundle.css', | ||
| }), | ||
|
There was a problem hiding this comment. i don't fully understand what this was doing, another for @pastelsky. it was writing the output to disk during watch mode i guess but to what end? the plugin doesn't support webpack 5 so im wondering/hoping we can drop it |
||
| ], | ||
| resolve: { | ||
| modules: ['node_modules'], | ||
|
|
@@ -135,22 +104,24 @@ export default function makeWebpackConfig({ | |
| test: /\.js$/, | ||
| use: [require.resolve('shebang-loader')], // support CLI tools that start with a #!/usr/bin/node | ||
| }, | ||
| { | ||
| test: /\.vue$/, | ||
| // NOTE: vue-loader has a side-effect here where it will also match | ||
| // *.vue.html, so it _must_ come before other .html loaders | ||
| use: 'vue-loader', | ||
| }, | ||
| { | ||
| test: /\.(html|svelte)$/, | ||
| use: { | ||
| loader: 'svelte-loader', | ||
| options: { | ||
| emitCss: true, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| test: /\.(scss|sass)$/, | ||
| use: [ | ||
| MiniCssExtractPlugin.loader, | ||
| require.resolve('css-loader'), | ||
| { | ||
|
|
@@ -174,7 +145,7 @@ export default function makeWebpackConfig({ | |
| }, | ||
| { | ||
| test: /\.less$/, | ||
| use: [ | ||
| MiniCssExtractPlugin.loader, | ||
| require.resolve('css-loader'), | ||
| { | ||
|
|
@@ -211,14 +182,14 @@ export default function makeWebpackConfig({ | |
| }, | ||
| ], | ||
| }, | ||
| node: false, | ||
| output: { | ||
| filename: 'bundle.js', | ||
| pathinfo: false, | ||
| }, | ||
| externals: ({ context, request }, callback) => | ||
| request && isExternalRequest(request) | ||
| ? callback(undefined, 'commonjs ' + request) | ||
| : callback(), | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pastelsky this has since changed in webpack. we now set
node: falseto tell it not to polyfill any builtins. but losing thisifconcerns me, would you be able to explain what the intention of this whole block was (builtInNode) and if disabling it entirely will suffice?