Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update log backup user docs #2641

Merged
merged 67 commits into from
Jan 20, 2025
Merged

update log backup user docs #2641

merged 67 commits into from
Jan 20, 2025

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Oct 25, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Added the description of new TiDB operator interface, including:

  1. Description of new spec field
  2. Introduction of auto-stop fucntion
  3. new example of log backup wrokflow

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Oct 25, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
csuzhangxc
csuzhangxc reviewed Nov 5, 2024
View reviewed changes
en/backup-restore-overview.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@RidRisR RidRisR requested a review from csuzhangxc November 18, 2024 04:20
csuzhangxc
csuzhangxc reviewed Nov 18, 2024
View reviewed changes
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-restore-cr.md Show resolved Hide resolved
zh/backup-restore-overview.md Outdated Show resolved Hide resolved
zh/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2024
csuzhangxc
csuzhangxc reviewed Nov 28, 2024
View reviewed changes
zh/backup-restore-overview.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-aws-s3-using-br.md Outdated Show resolved Hide resolved
en/backup-to-gcs-using-br.md Outdated Show resolved Hide resolved
RidRisR and others added 3 commits November 28, 2024 11:24
@RidRisR @csuzhangxc
Update zh/backup-restore-overview.md
dc23a0d 
Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
@RidRisR @csuzhangxc
Update en/backup-to-aws-s3-using-br.md
ef1a001 
Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
@RidRisR @csuzhangxc
Update en/backup-to-aws-s3-using-br.md
33b1b74 
Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
@csuzhangxc
Copy link
Member

@Oreoxmt PTAL again

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 9, 2025

@RidRisR https://github.com/pingcap/docs-tidb-operator/pull/2641/files#r1897171839

@Oreoxmt Oreoxmt self-requested a review January 17, 2025 02:57
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 17, 2025

@RidRisR I've submmitted a PR to align the English doc with the Chinese version and added some comments that need confirmation. PR link: https://github.com/RidRisR/docs-tidb-operator/pull/1/files

Oreoxmt
Oreoxmt reviewed Jan 20, 2025
View reviewed changes
zh/backup-restore-cr.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 20, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2024-11-29 07:08:16.649605029 +0000 UTC m=+793084.269259542: ☑️ agreed by csuzhangxc.
  • 2025-01-20 08:19:02.251453711 +0000 UTC m=+82469.582373115: ☑️ agreed by Oreoxmt.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 20, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 20, 2025
@Oreoxmt Oreoxmt closed this Jan 20, 2025
@Oreoxmt Oreoxmt reopened this Jan 20, 2025
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. label Jan 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 4b5cce2 into pingcap:master Jan 20, 2025
23 of 25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2688.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
7 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2689.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 20, 2025
Merged
7 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 20, 2025
@ti-chi-bot
update log backup user docs (#2641) (#2689)
ae901cd
ti-chi-bot bot pushed a commit that referenced this pull request Jan 21, 2025
@ti-chi-bot
update log backup user docs (#2641) (#2688)
1d14b14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RidRisR @CLAassistant @csuzhangxc @Oreoxmt @ti-chi-bot