Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: simplify interface to TWCC 1/4 #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jech
Copy link
Member

@jech jech commented Jan 13, 2025

This is part 1/4 of a cross-repository series.

Please do not merge until the series is complete.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.33%. Comparing base (82bca40) to head (7ae31d0).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
registry.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   71.26%   71.33%   +0.06%     
==========================================
  Files          80       80              
  Lines        4476     4486      +10     
==========================================
+ Hits         3190     3200      +10     
- Misses       1153     1154       +1     
+ Partials      133      132       -1     
Flag Coverage Δ
go 71.19% <0.00%> (+0.06%) ⬆️
wasm 69.34% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jech jech changed the title WIP: simplify interface to TWCC WIP: simplify interface to TWCC 1/4 Jan 13, 2025
@jech jech changed the title WIP: simplify interface to TWCC 1/4 Simplify interface to TWCC 1/4 Jan 13, 2025
@jech jech changed the title Simplify interface to TWCC 1/4 WIP: simplify interface to TWCC 1/4 Jan 13, 2025
@jech jech force-pushed the single-interceptor branch from a531522 to 1a82ea1 Compare January 13, 2025 17:34
Make Registry.Build take an optional list of extra interceptors
that are added before the ones specified by the registry.
@jech jech force-pushed the single-interceptor branch from 1a82ea1 to 7ae31d0 Compare January 13, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant