Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose deployment #4139

Closed
wants to merge 17 commits into from
Closed

Conversation

kevin-namba
Copy link
Contributor

What this PR does / why we need it:
Enable developers deploy control plane on local single machine using docker-compose

Which issue(s) this PR fixes:

Fixes #4129

Does this PR introduce a user-facing change?:

Support deploy control plane by using docker-compose

@khanhtc1202
Copy link
Member

LGTM with a nit. Any reason we have to store the docker-compose file in root? It mays confused our users that we only have docker-compose as the installer for pipecd. Do you guys have any idea to resolve that? 🤔

@kevin-namba
Copy link
Contributor Author

kevin-namba commented Feb 13, 2023

LGTM with a nit. Any reason we have to store the docker-compose file in root? It mays confused our users that we only have docker-compose as the installer for pipecd. Do you guys have any idea to resolve that? 🤔

I think We have two ways

  1. To store the docker-compose file in a directory under project root
    docker-compose name the project based on directory name that includes docker-compose.yaml, so we must name the directory a name such as "pipecd-control-plane"
  2. To store the docker-compose file in root and edit Makefile
    Many developers use Makefile to deploy control-plane, so they do not take care of the files in root. But we should write rules to deploy via docker-compose in Makefile.

@khanhtc1202
Copy link
Member

@kevin55156 okay, got it. Let's go with option 2 (since one more dir named pipecd-control-plane makes thing even harder to understand)

@khanhtc1202
Copy link
Member

Temporary close; we need to reconsider making this part of the main repo or pushing to a different one.

@khanhtc1202 khanhtc1202 deleted the add-docker-compose-deployment branch April 24, 2023 11:42
@t-kikuc
Copy link
Member

t-kikuc commented Mar 12, 2024

How about posting the example on PipeCD's official blog?

@t-kikuc
Copy link
Member

t-kikuc commented Mar 12, 2024

@t-kikuc
Copy link
Member

t-kikuc commented Mar 14, 2024

@kevin-namba
I posted a blog based on your gread idea and codes, thank you so much!
https://pipecd.dev/blog/2024/03/14/control-plane-on-local-by-docker-compose/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support install PipeCD control plane on other platform which is not k8s
4 participants