Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of local control plane by docker-compose #4822

Closed
wants to merge 2 commits into from

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Mar 12, 2024

What this PR does / why we need it:

Add an example of building a control plane locally by docker-compose
in order to enable users to experiment control plane / piped easily.

The codes are based on @kevin-namba 's #4139

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.94%. Comparing base (aeb3687) to head (bd585dd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4822      +/-   ##
==========================================
+ Coverage   28.91%   28.94%   +0.02%     
==========================================
  Files         317      317              
  Lines       40333    40333              
==========================================
+ Hits        11662    11674      +12     
+ Misses      27743    27731      -12     
  Partials      928      928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc
Copy link
Member Author

t-kikuc commented Mar 13, 2024

I will move this DEMO to another repository.

@t-kikuc t-kikuc closed this Mar 13, 2024
@ffjlabo
Copy link
Member

ffjlabo commented Mar 13, 2024

📝 talked in the public meeting

  • We will new repo to locate the docker compose file
  • For a demo, we should avoid locating it to the main repo

First, Add each component README link to the CONTRIBUTING.md
Later, let’s discuss more about the improvement

@t-kikuc t-kikuc deleted the example-control-plane-local branch April 9, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants