Support for R2DBC connections in DataSource processor. #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...nv-boot/src/main/java/io/pivotal/cfenv/spring/boot/CfDataSourceEnvironmentPostProcessor.java
Outdated
Show resolved
Hide resolved
|
ouch, once again I broke the PR pushing to your main. I guess contributors should always create a new branch than main, so that I don't accidentally delete their PR when I force push to their branch |
|
replicated in #272 |
anthonydahanne
added a commit
that referenced
this pull request
Aug 13, 2024
…essor. #262 (#272) * Support for R2DBC connections in DataSource processor. * Cleaning up some formatting. * Resolved style formatting issues. * Remove Greg MariadDB code * it's now handled directly in MySqlJdbcUrlCreator --------- Co-authored-by: meyerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java-cfenv-boot currently does not support setting R2DBC properties creating the necessity of developers to process VCAP_SERVICES themselves when they wish to autoconfigure R2DBC connections.
This enhancement mimics the Spring Cloud Bindings library in that it incorporates setting R2DBC properties (
spring.r2dbc.*) along side DataSource properties (spring.datasource.*) .