Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greg main - replaces Support for R2DBC connections in DataSource processor. #262 #272

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

anthonydahanne
Copy link
Member

basically, I just rebased on main #262, and removed @gm2552 code for MariaDB since it was merged already (support for mariadb)

@pivotal-david-osullivan , I could push spring-music with this branch and still get, with a bound mariadb, those properties from the actuator

 {
      "name": "cfenvjdbc",
      "properties": {
        "spring.datasource.url": {
          "value": "jdbc:mariadb://mad70744d.service.dc1.a9ssvc:3306/mad70744d?user=a9sa7fcc57a23fa9d05995dcd51c364&password=a9s6da4cc5f001593b8970eb5487f1fe148b281f476"
        },
        "spring.datasource.username": {
          "value": "a9sa7fcc57a23fa9d05995dcd51c364"
        },
        "spring.datasource.password": {
          "value": "a9s6da4cc5f001593b8970eb5487f1fe148b281f476"
        },
        "spring.datasource.driver-class-name": {
          "value": "org.mariadb.jdbc.Driver"
        },
        "spring.r2dbc.url": {
          "value": "r2dbc:mariadb://mad70744d.service.dc1.a9ssvc:3306/mad70744d"
        },
        "spring.r2dbc.username": {
          "value": "a9sa7fcc57a23fa9d05995dcd51c364"
        },
        "spring.r2dbc.password": {
          "value": "a9s6da4cc5f001593b8970eb5487f1fe148b281f476"
        },
        "spring.r2dbc.properties.password": {
          "value": "a9s6da4cc5f001593b8970eb5487f1fe148b281f476"
        },
        "spring.r2dbc.properties.user": {
          "value": "a9sa7fcc57a23fa9d05995dcd51c364"
        }
      }

(service was destroyed before adding this comment, no issue with credentials)

Good to go!!!! 🚀

* it's now handled directly in MySqlJdbcUrlCreator
@anthonydahanne anthonydahanne merged commit 68dfa18 into main Aug 13, 2024
1 check passed
@anthonydahanne anthonydahanne deleted the greg-main branch August 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants