Allow bulk deletion of Incomplete Submissions #10258
Conversation
There was a problem hiding this comment.
@taslangraham I just saw it's a work in progress, but sharing some nitpicks.
I've used the GitHub suggestions, so it's easier to pick the changes and do a single commit 😁
|
@jonasraoni Thanks for the early feedback! |
taslangraham
force-pushed
the
i6528-main
branch
5 times, most recently
from
daf8647 to
0211993
Compare
classes/submission/Collector.php
Outdated
| * @param int[] $submissionIds Submission IDs | ||
| */ | ||
| public function filterBySubmissionIds(array $submissionIds): static |
There was a problem hiding this comment.
I think null should be allowed to disable the filter.
| * @param int[] $submissionIds Submission IDs | |
| */ | |
| public function filterBySubmissionIds(array $submissionIds): static | |
| * @param ?int[] $submissionIds Submission IDs | |
| */ | |
| public function filterBySubmissionIds(?array $submissionIds): static |
| @@ -34,7 +34,7 @@ class SubmissionAccessPolicy extends ContextPolicy | |||
| * @param array $roleAssignments | |||
| * @param string $submissionParameterName the request parameter we | |||
| * expect the submission id in. | |||
| * @param bool $permitDeclined True iff declined reviews are permitted for viewing by reviewers | |||
| * @param bool $permitDeclined True if declined reviews are permitted for viewing by reviewers | |||
There was a problem hiding this comment.
I thought it was a typo as well, but it means "if and only if" 😁
taslangraham
force-pushed
the
i6528-main
branch
from
0211993 to
04b0410
Compare
|
thanks for the review @jonasraoni |
| Repo::submission()->delete($submission); | ||
| } | ||
|
|
||
| return response()->json([], Response::HTTP_OK); |
There was a problem hiding this comment.
Perhaps the frontend won't be very friendly with that, but the response()->noContent() would fit better :)
|
Please, this feature would be great!! |
taslangraham
force-pushed
the
i6528-main
branch
from
04b0410 to
7016b30
Compare
locale/en/common.po
Outdated
| msgid "common.deselectAll" | ||
| msgstr "Deselect All" |
There was a problem hiding this comment.
@jardakotesovec I'm not sure if your UI implementation uses this and the entry below. If not I'll remove them
taslangraham
force-pushed
the
i6528-main
branch
from
c0730eb to
d4858dc
Compare
taslangraham
force-pushed
the
i6528-main
branch
3 times, most recently
from
1b60ce4 to
80dee35
Compare
taslangraham
force-pushed
the
i6528-main
branch
from
80dee35 to
6fe672b
Compare
For #6528