Cleanup patterns settings #3765
Conversation
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
is this addressing #3633 too? |
petschki
force-pushed
the
cleanup-patterns
branch
from
69ad4b4 to
d98f3ce
Compare
|
Does it need an upgrade step to remove existing entries from registry? |
I think so. I added this to the Buschenschanksprint project page. Would be an easy task to do there. |
I'll look into it. |
|
Please check plone/plone.app.upgrade#328 I don't think I've ever done a PR to plone.app.upgrade, so I might be doing something wrong... |
… ITinyMCESpellCheckerForm.
mauritsvanrees
force-pushed
the
cleanup-patterns
branch
from
05b2fd9 to
848321c
Compare
|
Tests failed due to changes missing from master. I did a rebase and will restart the jobs. |
|
All green, I merge. |
Branch: refs/heads/master Date: 2024-06-18T14:09:26+02:00 Author: Manuel Reinhardt (reinhardt) <[email protected]> Commit: plone/plone.app.upgrade@332b770 Add upgrade step that removes AtD settings See plone/Products.CMFPlone#3765 Files changed: A plone/app/upgrade/v61/profiles.zcml A plone/app/upgrade/v61/profiles/to6103/registry.xml M plone/app/upgrade/v61/configure.zcml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-06-18T18:30:16+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.upgrade@d977aeb Hide plone.app.upgrade.v61 from products. Files changed: M plone/app/upgrade/__init__.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-06-19T15:20:02+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.upgrade@8bf1dfb Merge pull request #328 from plone/cleanup-patterns Add upgrade step that removes AtD settings Files changed: A plone/app/upgrade/v61/profiles.zcml A plone/app/upgrade/v61/profiles/to6103/registry.xml M plone/app/upgrade/__init__.py M plone/app/upgrade/v61/configure.zcml
Branch: refs/heads/master Date: 2024-06-18T14:09:26+02:00 Author: Manuel Reinhardt (reinhardt) <[email protected]> Commit: plone/plone.app.upgrade@332b770 Add upgrade step that removes AtD settings See plone/Products.CMFPlone#3765 Files changed: A plone/app/upgrade/v61/profiles.zcml A plone/app/upgrade/v61/profiles/to6103/registry.xml M plone/app/upgrade/v61/configure.zcml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-06-18T18:30:16+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.upgrade@d977aeb Hide plone.app.upgrade.v61 from products. Files changed: M plone/app/upgrade/__init__.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2024-06-19T15:20:02+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.upgrade@8bf1dfb Merge pull request #328 from plone/cleanup-patterns Add upgrade step that removes AtD settings Files changed: A plone/app/upgrade/v61/profiles.zcml A plone/app/upgrade/v61/profiles/to6103/registry.xml M plone/app/upgrade/__init__.py M plone/app/upgrade/v61/configure.zcml
This PR removes the "After the deadline" plugin, which is dead code.
It removes the relevant code parts without a deprecation warning, which is probably not acceptable.
How should I proceed here? Deprecate it for 6.0 and let it be removed for 6.1? Or should this breaking change to into 7.0?
It's not an urgent issue but would remove some code which is most probably unused.
Together:
#3765
plone/plone.base#33
plone/plone.api#504mergedplone/plone.app.upgrade#328
Jenkins:
https://jenkins.plone.org/job/pull-request-6.1-3.11/156/