Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade step that removes AtD settings #328

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

reinhardt
Copy link
Contributor

See plone/Products.CMFPlone#3765

Is this the right place to add the upgrade? Should I create a new version?

Should I add a towncrier entry?

@reinhardt reinhardt requested review from thet and mauritsvanrees June 18, 2024 12:14
@mister-roboto
Copy link

@reinhardt thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@reinhardt
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

Missing a changelog entry. Jenkins is currently running, so let's not bother at this moment. Once it is finished, we can merge all. And then I can add the changelog entry directly on master.

Remind me if I forget. :-)

@reinhardt
Copy link
Contributor Author

Missing a changelog entry. Jenkins is currently running, so let's not bother at this moment. Once it is finished, we can merge all. And then I can add the changelog entry directly on master.

Remind me if I forget. :-)

There's already “Added upgrade to 6103, Plone 6.1.0a4.”: https://github.com/plone/plone.app.upgrade/blob/master/news/6103.internal

Does that count?

@mauritsvanrees mauritsvanrees merged commit 8bf1dfb into master Jun 19, 2024
5 of 6 checks passed
@mauritsvanrees mauritsvanrees deleted the cleanup-patterns branch June 19, 2024 13:20
@mauritsvanrees
Copy link
Member

There's already “Added upgrade to 6103, Plone 6.1.0a4.”: https://github.com/plone/plone.app.upgrade/blob/master/news/6103.internal

Does that count?

No, I like to be more specific. :-)
I added a snippet in commit d6d277f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants