Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Add Trusted Nodes #29

Merged
merged 12 commits into from
Oct 8, 2024
Merged

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Add Trusted Nodes #29

merged 12 commits into from
Oct 8, 2024

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Sep 12, 2024

The "Add Trusted Nodes" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-blockchain/add-trusted-nodes/

@0xLucca 0xLucca requested a review from nhussein11 September 12, 2024 18:39
github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 self-requested a review September 18, 2024 20:13
@0xLucca 0xLucca requested a review from eshaben September 25, 2024 13:21
@eshaben eshaben requested a review from dawnkelly09 October 1, 2024 18:59
dawnkelly09
dawnkelly09 requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some things :-)

tutorials/polkadot-sdk/build-a-blockchain/.pages Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
@dawnkelly09 dawnkelly09 requested a review from nhussein11 October 2, 2024 17:42
@dawnkelly09 dawnkelly09 mentioned this pull request Oct 2, 2024
Merged
@0xLucca 0xLucca requested a review from dawnkelly09 October 3, 2024 11:54
@0xLucca
Copy link
Collaborator Author

0xLucca commented Oct 3, 2024

Let's merge this page to this section, and then we can relocate it after the migration

@0xLucca 0xLucca requested a review from a team as a code owner October 3, 2024 20:39
eshaben
eshaben previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nhussein11
nhussein11 previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CrackTheCode016
CrackTheCode016 reviewed Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is fine, but we should be using chain-spec-builder to maintain consistency. We have two options:

  1. We merge this now as-is, which works, but will need updating down the line later.
  2. We add chain-spec-builder, of which the steps could be:
    a. Create a patch file with the aura / grandpa keys
    b. Use chain-spec-builder w/ the patch file to generate the spec

tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Show resolved Hide resolved
@dawnkelly09 dawnkelly09 dismissed stale reviews from nhussein11 and eshaben via 0b9371e October 7, 2024 16:37
dawnkelly09
dawnkelly09 reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some edits so I will ask Erin for review to check my work

@dawnkelly09 dawnkelly09 requested a review from eshaben October 7, 2024 16:38
eshaben
eshaben reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out a couple of the commands, cause I was just curious if that was the entire output or not since I had no idea. Found a couple small discrepancies

.snippets/code/tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes/key-sr25519-1.html Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes.md Outdated Show resolved Hide resolved
.snippets/code/tutorials/polkadot-sdk/build-a-blockchain/add-trusted-nodes/key-ed25519-1.html Outdated Show resolved Hide resolved
@eshaben eshaben requested review from dawnkelly09 and a team October 8, 2024 06:21
dawnkelly09
dawnkelly09 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@eshaben eshaben merged commit b5762de into master Oct 8, 2024
@eshaben eshaben deleted the psdk-build-a-blockchain-2 branch October 8, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@nhussein11 nhussein11 nhussein11 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xLucca @eshaben @CrackTheCode016 @nhussein11 @dawnkelly09