Makefile: unset GOOS for get-envoy command #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ingress Controller can be built on macOS by running a command like GOOS=linux make build && docker build . -t ingress-controller:dev except that this will attempt to build and run the get-envoy command for Linux as well, which won't work. Let's update the Makefile 'envoy' target to unset the GOOS variable so that the get-envoy command is always built for the host OS.
calebdoxsey
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ingress Controller can be built on macOS by running a command like
except that this will attempt to build and run the
get-envoycommand for Linux as well, which won't work. Let's update the Makefile 'envoy' target to unset the GOOS variable so that the get-envoy command is always built for the host OS.Related issues
Checklist
improvement/bug/ etc)