Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated plugin generator to use SCI types #91

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Conversation

eddie-knight
Copy link
Contributor

Part of #90

  • Changed from using our custom types to using the SCI types
  • Added prettify template function to streamline the underscore/dot fixes
  • renamed objects.go -> types.go just for kicks

@eddie-knight eddie-knight requested a review from a team as a code owner February 23, 2025 22:22
@eddie-knight eddie-knight changed the title Updated plugin generator to use SCI types feat: Updated plugin generator to use SCI types Feb 23, 2025
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some serious nested for loops but makes sense. I could have sworn the dash and underscore replacements were upstream but we still have to do them downstream? Not blocking questions.

@eddie-knight
Copy link
Contributor Author

@jmeridth We've been doing it here — not sure if we can manage it in the SCI library. There are some cases where we need to clean up the value and other places where we want to keep it the same as it appears in the control catalog.

@eddie-knight eddie-knight merged commit 177c1ad into main Feb 23, 2025
5 of 6 checks passed
@eddie-knight eddie-knight deleted the feat/generator branch February 23, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants