-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-5137] Azure managed summary #5475
Conversation
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5475 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 371 371
Lines 31624 31638 +14
Branches 3387 3388 +1
=======================================
+ Hits 29756 29766 +10
- Misses 1217 1218 +1
- Partials 651 654 +3 |
AND year = {{year}} | ||
AND month= {{month}}; | ||
|
||
INSERT INTO hive.{{schema | sqlsafe}}.managed_azure_uuid_temp ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AND azure.date >= {{start_date}} | ||
AND azure.date < date_add('day', 1, {{end_date}}); | ||
|
||
CREATE TABLE IF NOT EXISTS hive.{{schema | sqlsafe}}.managed_azure_openshift_daily_temp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to rename these tables to better match our flow now is our chance. For example this table is where we start doing resource matching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is always fun. Do you have suggestions here at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what I have named them so far 😂 Mostly wanted to call it out in case people had preferences.
Jira Ticket
COST-5137
Description
This change will:
Instead of having one long 1500 line sql file, we have different stages of progress.
During the daily aggregation flow we also handle some data transformation such as:
As the features we support continue to grow, the size of these files will as well. Therefore, we now have the ability to chunk out the files as we see fit. Personally in the future I would like to break out the network & storage unattributed data transformations from the daily aggregation logic. But that is outside the scope of this issue.
Testing
Example:
You will notice an additional cost that doesn't have a resource_id. That cost is related to tag matching rows. Apparently tag matching just doesn't work in our old flow.
Release Notes