[3100-highlight] When no highlighted field is available fall back into the field value #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the field value. Co-authored-by: Jane Sandberg <[email protected]> Co-authored-by: Vickie Karasic <[email protected]>
christinach
force-pushed
the
3100-highlight
branch
from
3044191
to
8a172ab
Compare
tpendragon
approved these changes
Nov 8, 2023
| retrieve_simple | ||
| end | ||
| ) | ||
| if field_config.highlight |
There was a problem hiding this comment.
It's funny, I almost wish that the retrieve_ methods just returned nil if accessor or values or whatever wasn't set, so we could do retrieve_highlight || retrieve_using_accessor || retrieve_values || retrieve_simple, but that's probably too big for here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3100