You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@zestyping MySQL starts encrypting tables on a background thread when encryption is enabled. As a result, there's no obvious way to know when the job is done. This test makes the assumption that if at least one of the openmrs tables is encrypted, then the server background thread is doing its work and all openmrs tables will be encrypted eventually. I'll comment this assumption in the test.
32632c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
-gt 0
mean this only checks if at least one table is encrypted? Don't we want all the tables to be encrypted?32632c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zestyping MySQL starts encrypting tables on a background thread when encryption is enabled. As a result, there's no obvious way to know when the job is done. This test makes the assumption that if at least one of the openmrs tables is encrypted, then the server background thread is doing its work and all openmrs tables will be encrypted eventually. I'll comment this assumption in the test.