-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processing] Brand new generate elevation profile image algorithm #59061
Conversation
6d23f91
to
73a935e
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
97b20c5
to
3eb0feb
Compare
5762249
to
81ca4f7
Compare
src/analysis/processing/qgsalgorithmgenerateelevationprofile.cpp
Outdated
Show resolved
Hide resolved
dpiParam->setFlags( dpiParam->flags() | Qgis::ProcessingParameterFlag::Advanced ); | ||
addParameter( dpiParam.release() ); | ||
|
||
addParameter( new QgsProcessingParameterFileDestination( QStringLiteral( "OUTPUT" ), QObject::tr( "Output image" ) ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the same logic as QgsLayoutToImageAlgorithm to set the file filters here
src/analysis/processing/qgsalgorithmgenerateelevationprofile.cpp
Outdated
Show resolved
Hide resolved
81ca4f7
to
524239d
Compare
524239d
to
6ba10d4
Compare
Tests failed for Qt 5One or more tests failed using the build from commit 6ba10d4 generate_elevation_profile (generateElevationProfileImage)generate_elevation_profileTest failed at generateElevationProfileImage at tests/src/analysis/testqgsprocessingalgspt2.cpp:1992 Rendered image did not match tests/testdata/control_images/processing_algorithm/expected_generate_elevation_profile/expected_generate_elevation_profile.png (found 21082 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 6One or more tests failed using the build from commit 6ba10d4 generate_elevation_profile (generateElevationProfileImage)generate_elevation_profileTest failed at generateElevationProfileImage at tests/src/analysis/testqgsprocessingalgspt2.cpp:1992 Rendered image did not match tests/testdata/control_images/processing_algorithm/expected_generate_elevation_profile/expected_generate_elevation_profile.png (found 28482 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
6ba10d4
to
a23d131
Compare
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
@nirvn A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
@nirvn |
Description
This PR adds a brand new generate elevation profile image algorithm to the processing toolbox:
This can come in super handy as part of models that need to output elevation profiles for multiple curves.
I've tried to find a balance in picking the parameters exposed here. There would be plenty more to do, but unsure how much further we should go :)
By default, the algorithm will set the elevation profile plot's distance (X axis) and elevation (Y axis)'s minimum and maximum to match the curve length and Z range of the rendered layers. Users can manually overwrite these set via advanced parameters: