Define ruby version and gemset #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filabreu
requested changes
Oct 6, 2016
| @@ -33,9 +33,6 @@ gem 'jbuilder', '~> 2.5' | |||
| group :development, :test do | |||
| # Call 'byebug' anywhere in the code to stop execution and get a debugger console | |||
| gem 'byebug', platform: :mri | |||
| gem 'rspec-rails' | |||
| gem 'factory_girl_rails' | |||
| gem 'database_cleaner' | |||
There was a problem hiding this comment.
We should keep at least rspec-rails and factory_girl_rails in the development group, so when we use generators for models, controllers, views and helpers, our spec files and factories are automatically created as well.
The database_cleaner gem could be left out the development group, but wouldn't hurt to have it into too. And as we didn't have a test group into the Gemfile, I opted to leave on the development, test group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .ruby-version
Add .ruby-gemset
Change Gemfile