Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ruby version and gemset #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Define ruby version and gemset #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d7f76e
[Change] Update Gemfile, create group :test
Oct 6, 2016
644627b
Add .ruby-version
Oct 6, 2016
ca68c0a
Add .ruby-gemset
Oct 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ruby-gemset
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
decide
1 change: 1 addition & 0 deletions .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.3.1
9 changes: 6 additions & 3 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ gem 'jbuilder', '~> 2.5'
group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
gem 'byebug', platform: :mri
gem 'rspec-rails'
gem 'factory_girl_rails'
gem 'database_cleaner'
end

group :development do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep at least rspec-rails and factory_girl_rails in the development group, so when we use generators for models, controllers, views and helpers, our spec files and factories are automatically created as well.

The database_cleaner gem could be left out the development group, but wouldn't hurt to have it into too. And as we didn't have a test group into the Gemfile, I opted to leave on the development, test group

Expand All @@ -49,3 +46,9 @@ end

# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]

group :test do
gem 'rspec-rails'
gem 'factory_girl_rails'
gem 'database_cleaner'
end