gh #29 WB and CMS Header changes #30

aktamilbe · 2024-08-08T11:59:40Z

No description provided.

CLAassistant · 2024-08-08T11:59:46Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ hari22yuva
✅ aktamilbe
✅ ashishkumarrai1998
❌ tamilselvanak
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…_hal_bugs_fixes gh #25 l1 tvsettings hal bugs fixes

v2.0.0

include/tvSettings.h

tsenapathy

added comments, please check. I see it's only custom 2 point WB. So, it's all for user configurable 2 point white balance. (not for factory use).

…tvsettings into feature/AVOutput_Porting

Anbukannadhasan

Added review comments

config/pq_capabilities.ini

include/tvSettings.h

include/tvSettingsODM.h

include/tvTypes.h

config/pq_capabilities.ini

include/tvTypes.h

include/tvSettings.h

Anbukannadhasan

Added review comments

include/tvSettings.h

tsenapathy · 2025-01-10T10:54:10Z

pls check

Anbukannadhasan

Approved

Anbukannadhasan

Approved

hari22yuva

please check review comments

hari22yuva · 2025-01-20T10:50:04Z

config/pq_capabilities.ini

@@ -119,150 +119,6 @@ format = SDR,HDR10,HLG,DV
 source = All,Composite1,HDMI1,HDMI2,HDMI3,IP,Tuner
 platformsupport = true


why always the name of the file is changing?
and we need less update this file and we need add only new feature parameters, not modify old once

1.Its a spelling mistake which is corrected now. It was missed in previous reviews.
2.Currently CMS has total 18 entries in pq_capabilities.ini. To make it more convenient we have combined all 18 entries into single entry like below and added corresponding code changes in HAL.
[CMS]
range_Saturation_from = 0
range_Saturation_to = 100
range_Hue_from = 0
range_Hue_to = 100
range_Luma_from = 0
range_Luma_to = 30
color = Red,Green,Blue,Cyan,Magenta,Yellow
component = Saturation,Hue,Luma
pqmode = Entertainment,Dynamic,Expert,Movie,Sports,Graphics,Dynamic2
format = SDR,HDR10,HLG,DV
source = All,Composite1,HDMI1,HDMI2,HDMI3,IP,Tuner
I have already updated this in description.

Tvsettings-hal is improving every day and we can expect more changes in future too.

if we have any other entries like this please do it now

As part of this ticket we have worked on Custom WhiteBalance and CMS.
This ticket is meant for include above features to AVOutput plugin.
Remaining things will be handled on new ticket only.

hari22yuva · 2025-01-20T10:52:36Z

include/tvSettings.h

+ *
+ * @pre TvInit() should be called before calling this API
+ */
+tvError_t SetCustom2PointWhiteBalance(tvWBColor_t color, tvWBControl_t control, int value);


why numeric number in the function? is that required ?
Update https://github.com/rdkcentral/rdkv-halif-tvsettings/blob/main/docs/pages/tv-settings_halSpec.md
with this new api

why numeric number in the function? is that required ?
Yes, It is Custom WhiteBalance Value to be set. Valid range gain (0 - 2047) and offset (-1024 to 1023)

updated new Enum in hal-spec.md

sorry maybe confused
why function name like this SetCustom2PointWhiteBalance

CustomWhiteBalance changes only affects the Custom/User Color temperature. So only it named as Custom2PointWhiteBalance.

Updated this information already in both set and get.

Set:
The Custom WhiteBalance (Red, Green, Blue Gain/Offset) is applicable only when the color temperature is set to tvColorTemp_USER.

Get:
The function always retrieves the custom WhiteBalance (Red, Green, Blue Gain/Offset) associated with tvColorTemp_USER.

hari22yuva · 2025-01-20T10:53:24Z

include/tvSettings.h

+ *
+ * This function sets WhiteBalance (Red,Green,Blue Gain/Offset) for the current picture mode index, current video source,
+ * and current video format.
+ * The custom WhiteBalance (Red, Green, Blue Gain/Offset) is applicable only when the color temperature is set to tvColorTemp_USER.


how we can very the color temperature is set to tvColorTemp_USER.

Already We have API for this GetColorTemperature( ) in tvSettings.h

so for this API, SetColorTemperature( ) is pre-requisite?

Yes Its caller responsibility to set the color Temperature to "tvColorTemp_USER." before calling this function.
I will update it.

It depends on the platforms. Some platforms allow all colour temperatures to be customised. So customer can have their preferred cool, warm and normal colour temperature.

aktamilbe added 4 commits August 30, 2024 12:09

gh #28 WB and CMS Header changes

6934290

gh #28 Add Capability header changes

5d2d282

gh #28 Add HDRMode and capablity changes

d57467e

gh #28 HDRMode header changes

47f483c

aktamilbe force-pushed the feature/AVOutput_Porting branch from e777ba5 to 47f483c Compare August 30, 2024 12:05

aktamilbe and others added 17 commits August 30, 2024 13:57

gh #29 Removed colorTemp and Cap API

e7ddf52

gh #29 Corrected GetPQParams Arguments

969b074

Merge branch 'develop' into feature/AVOutput_Porting

c9b90f7

gh #29 add CustomWB set API

57c9190

Merge branch 'develop' into feature/AVOutput_Porting

d6440ba

gh #29 add WB API

df473e2

removing Capability file changes from this issue

0f161f1

Added Vivid2 PQ index and pq capability files

875ca53

Updated error in GetTVGammaTarget

54809cd

Added seprate LLama capability files

9645f2d

Removed unwanted pq_capabilities.ini

6fd723b

Merge pull request #33 from rdkcentral/feature/issues25_L1_tvsettings…

6dd69f0

…_hal_bugs_fixes gh #25 l1 tvsettings hal bugs fixes

Bumped CHANGELOG.md - 2.0.0

68040e7

Merge branch 'release/2.0.0'

4d46e75

Merge tag '2.0.0' into develop

aef21d5

v2.0.0

gh #29 resolved merge conflicts

946f319

gh #29 added GetSuctomWhiteBalance API

9ef6722

hari22yuva force-pushed the develop branch from aef21d5 to d5ef30e Compare November 8, 2024 16:49

gh #29 Resolved Merge Conflicts

5fe516c

srinivasgtl requested review from tsenapathy, Anbukannadhasan and hari22yuva December 12, 2024 07:37

srinivasgtl assigned aktamilbe Dec 12, 2024

srinivasgtl added the enhancement New feature or request label Dec 12, 2024

tsenapathy reviewed Dec 12, 2024

View reviewed changes

include/tvSettings.h Show resolved Hide resolved

tsenapathy reviewed Dec 12, 2024

View reviewed changes

aktamilbe and others added 3 commits December 13, 2024 06:15

Merge branch 'develop' of rdkcentral-github.com:rdkcentral/rdk-halif-…

b10c99e

…tvsettings into feature/AVOutput_Porting

gh #29 Cleanup and updated review comments

60e1494

gh #29 Remove HDRMode reference

46051e0

Anbukannadhasan reviewed Dec 27, 2024

View reviewed changes

aktamilbe added 2 commits December 27, 2024 12:20

gh #29 Update review comments

9fe2e47

gh #29 added HDRMode in capability

25cb9ef

lucienkennedylamb suggested changes Dec 30, 2024

View reviewed changes

config/pq_capabilities.ini Outdated Show resolved Hide resolved

include/tvTypes.h Outdated Show resolved Hide resolved

include/tvTypes.h Outdated Show resolved Hide resolved

include/tvSettings.h Outdated Show resolved Hide resolved

aktamilbe added 4 commits January 2, 2025 06:03

gh #29 Updated review comments

841fdde

gh #29 Updated BacklightControl capability

ce7e316

gh #29 Updated capability review comments

c9c7a9b

gh #29 removed unused section from capability

a95666a

Anbukannadhasan reviewed Jan 8, 2025

View reviewed changes

include/tvSettings.h Outdated Show resolved Hide resolved

include/tvSettings.h Outdated Show resolved Hide resolved

include/tvSettings.h Show resolved Hide resolved

gh #29 updated review comments

ccc0be7

lucienkennedylamb approved these changes Jan 14, 2025

View reviewed changes

Anbukannadhasan previously approved these changes Jan 14, 2025

View reviewed changes

gh #29 added HDRMode Index

9f78db4

aktamilbe dismissed Anbukannadhasan’s stale review via 9f78db4 January 20, 2025 07:27

Anbukannadhasan previously approved these changes Jan 20, 2025

View reviewed changes

tsenapathy previously approved these changes Jan 20, 2025

View reviewed changes

hari22yuva requested changes Jan 20, 2025

View reviewed changes

gh #29 added custom WB enum in halspec

67bb3c6

aktamilbe dismissed stale reviews from tsenapathy and Anbukannadhasan via 67bb3c6 January 20, 2025 12:44

lucienkennedylamb approved these changes Jan 20, 2025

View reviewed changes

gh #29 added pre-requistite for setcustom2PtWhiteBalance

20dbe79

aktamilbe mentioned this pull request Jan 21, 2025

gh #29 TVS Header changes for AVoutput new features #51

Merged

hari22yuva removed a link to an issue Jan 24, 2025

TVS-HAL changes for AVOutput #29

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh #29 WB and CMS Header changes #30

gh #29 WB and CMS Header changes #30

aktamilbe commented Aug 8, 2024

CLAassistant commented Aug 8, 2024 •

edited

Loading

tsenapathy left a comment

Anbukannadhasan left a comment

Anbukannadhasan left a comment

tsenapathy commented Jan 10, 2025

Anbukannadhasan left a comment

Anbukannadhasan left a comment

hari22yuva left a comment

hari22yuva Jan 20, 2025

aktamilbe Jan 20, 2025

hari22yuva Jan 20, 2025

aktamilbe Jan 20, 2025 •

edited

Loading

hari22yuva Jan 20, 2025

aktamilbe Jan 20, 2025

hari22yuva Jan 20, 2025

aktamilbe Jan 20, 2025

hari22yuva Jan 20, 2025

aktamilbe Jan 20, 2025

hari22yuva Jan 20, 2025

aktamilbe Jan 20, 2025

utkarshece14 Jan 20, 2025

		@@ -119,150 +119,6 @@ format = SDR,HDR10,HLG,DV
		source = All,Composite1,HDMI1,HDMI2,HDMI3,IP,Tuner
		platformsupport = true

gh #29 WB and CMS Header changes #30

Are you sure you want to change the base?

gh #29 WB and CMS Header changes #30

Conversation

aktamilbe commented Aug 8, 2024

CLAassistant commented Aug 8, 2024 • edited Loading

tsenapathy left a comment

Choose a reason for hiding this comment

Anbukannadhasan left a comment

Choose a reason for hiding this comment

Anbukannadhasan left a comment

Choose a reason for hiding this comment

tsenapathy commented Jan 10, 2025

Anbukannadhasan left a comment

Choose a reason for hiding this comment

Anbukannadhasan left a comment

Choose a reason for hiding this comment

hari22yuva left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aktamilbe Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Aug 8, 2024 •

edited

Loading

aktamilbe Jan 20, 2025 •

edited

Loading