gh #29 WB and CMS Header changes #30
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2622,6 +2622,79 @@ tvError_t GetLdimZoneShortCircuitStatus(unsigned char* shortcircuit_zone_list, u | |
| */ | ||
| tvError_t GetNumberOfDimmingZones(unsigned int* number_of_dimming_zones); | ||
|
|
||
| /** | ||
| * @brief Sets 2Point Custom Whitebalance | ||
| * | ||
| * This function sets Whitebalance for a current picture mode index, primary video source @n | ||
tsenapathy marked this conversation as resolved.
Show resolved
Hide resolved
Anbukannadhasan marked this conversation as resolved.
Show resolved
Hide resolved
aktamilbe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * and primary video format. | ||
| * | ||
| * @param[in] color - Color type value. Valid value will be a member of ::tvWBColor_t | ||
| * @param[in] control - Control index value. Valid values will be a member of ::tvWBControl_t | ||
| * @param[in] value - The WhiteBalance Value to be set.Valid range gain (0 - 2047) and offset (-1024 to 1023) | ||
| * | ||
| * @return tvError_t | ||
| * | ||
| * @retval tvERROR_NONE - Success | ||
| * @retval tvERROR_INVALID_PARAM - Input parameter is invalid | ||
| * @retval tvERROR_INVALID_STATE - Interface is not initialized | ||
| * @retval tvERROR_OPERATION_NOT_SUPPORTED - Operation is not supported | ||
| * @retval tvERROR_GENERAL - Underlying failures - SoC, memory, etc | ||
| * | ||
| * @pre TvInit() should be called before calling this API | ||
| */ | ||
| tvError_t SetCustom2PointWhiteBalance(tvWBColor_t color, tvWBControl_t control, int value); | ||
|
There was a problem hiding this comment. why numeric number in the function? is that required ? There was a problem hiding this comment. why numeric number in the function? is that required ? updated new Enum in hal-spec.md There was a problem hiding this comment. sorry maybe confused There was a problem hiding this comment. CustomWhiteBalance changes only affects the Custom/User Color temperature. So only it named as Custom2PointWhiteBalance. Updated this information already in both set and get. Set: Get: |
||
|
|
||
| /** | ||
| * @brief Gets the current Custom WhiteBalance | ||
| * | ||
| * This function gets the current WhiteBalance value for the primary video source selected, | ||
Anbukannadhasan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * primary video format played,picture mode selected,given color and given control value.. | ||
tsenapathy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * @param[in] color - Color type value. Valid value will be a member of ::tvWBColor_t | ||
| * @param[in] control - Control index value. Valid values will be a member of ::tvWBControl_t | ||
| * @param[out] value - Current WB value. Valid range gain (0 - 2047) and offset (-1024 to 1023) | ||
| * | ||
| * @return tvError_t | ||
| * | ||
| * @retval tvERROR_NONE - Success | ||
| * @retval tvERROR_INVALID_PARAM - Parameter is invalid | ||
| * @retval tvERROR_INVALID_STATE - Interface is not initialized | ||
| * @retval tvERROR_GENERAL - Underlying failures - SoC, memory, etc | ||
| * | ||
| * @pre TvInit() should be called before calling this API | ||
| * | ||
| * @see SetCustom2PointWhiteBalance() | ||
| */ | ||
| tvError_t GetCustom2PointWhiteBalance(tvWBColor_t color, tvWBControl_t control, int *value); | ||
tsenapathy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * @brief Saves WhiteBalance | ||
| * | ||
| * This function saves the WhiteBalance in picture profile database for the specific primary video format type | ||
| * and primary video source. The saved Whitebalance value should be applied automatically whenever the | ||
Anbukannadhasan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * specified specified primary video format is played and specified primary video source is selected. | ||
tsenapathy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * @param[in] videoSrcType - Source input value.Valid value will be a member of ::tvVideoSrcType_t | ||
| * @param[in] pictureMode - Picture mode value to be saved.Valid values are as per values returned by | ||
| * ::pic_modes_t.value parmeter from GetTVSupportedPictureModes API. | ||
| * @param[in] videoFormatType - Video format type value.Valid value will be a member of ::tvVideoFormatType_t | ||
| * @param[in] color - color value.Valid value will be a member of ::tvWBColor_t | ||
| * @param[in] control - control value.Valid value will be a member of ::tvWBControl_t | ||
| * @param[in] value - The WhiteBalance value to be set.Valid range gain (0 - 2047) and offset (-1024 to 1023) | ||
| * | ||
Anbukannadhasan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @return tvError_t | ||
| * | ||
| * @retval tvERROR_NONE - Success | ||
| * @retval tvERROR_INVALID_PARAM - Input parameter is invalid | ||
| * @retval tvERROR_INVALID_STATE - Interface is not initialized | ||
| * @retval tvERROR_OPERATION_NOT_SUPPORTED - Operation is not supported | ||
| * @retval tvERROR_GENERAL - Underlying failures - SoC, memory, etc | ||
| * | ||
| * @pre TvInit() should be called before calling this API | ||
| */ | ||
|
|
||
| tvError_t SaveCustom2PointWhiteBalance(tvVideoSrcType_t videoSrcType, int pq_mode,tvVideoFormatType_t videoFormatType, tvWBColor_t color, tvWBControl_t control, int value); | ||
tsenapathy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why always the name of the file is changing?
and we need less update this file and we need add only new feature parameters, not modify old once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.Its a spelling mistake which is corrected now. It was missed in previous reviews.
2.Currently CMS has total 18 entries in pq_capabilities.ini. To make it more convenient we have combined all 18 entries into single entry like below and added corresponding code changes in HAL.
[CMS]
range_Saturation_from = 0
range_Saturation_to = 100
range_Hue_from = 0
range_Hue_to = 100
range_Luma_from = 0
range_Luma_to = 30
color = Red,Green,Blue,Cyan,Magenta,Yellow
component = Saturation,Hue,Luma
pqmode = Entertainment,Dynamic,Expert,Movie,Sports,Graphics,Dynamic2
format = SDR,HDR10,HLG,DV
source = All,Composite1,HDMI1,HDMI2,HDMI3,IP,Tuner
I have already updated this in description.
Tvsettings-hal is improving every day and we can expect more changes in future too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we have any other entries like this please do it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this ticket we have worked on Custom WhiteBalance and CMS.
This ticket is meant for include above features to AVOutput plugin.
Remaining things will be handled on new ticket only.