Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reana-dev): use chore commit scope when bumping dependencies #868

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

tiborsimko
Copy link
Member

For commits created by reana-dev git-upgrade-shared-modules and reana-dev git-upgrade-requirements commands, use "chore" rather than "build" conventional commit scope, so that these commits won't appear in the release news message.

The bug fixes or new features that are brought by upgrades are announced in the release news in another way, such as when a feature needs the new shared package or an upgraded version of dependency. The pre-release version bumps can therefore go without a release news item.

@tiborsimko tiborsimko self-assigned this Feb 3, 2025
…nahub#868)

For commits created by `reana-dev git-upgrade-shared-modules` and
`reana-dev git-upgrade-requirements` commands, use "chore" rather than
"build" conventional commit scope, so that these commits won't appear in
the release news message.

The bug fixes or new features that are brought by upgrades are announced
in the release news in another way, such as when a feature needs the new
shared package or an upgraded version of dependency. The pre-release
version bumps can therefore go without a release news item.
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.04%. Comparing base (8acfb28) to head (3788789).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
reana/reana_dev/git.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   31.04%   31.04%           
=======================================
  Files          26       26           
  Lines        2500     2500           
=======================================
  Hits          776      776           
  Misses       1724     1724           
Files with missing lines Coverage Δ
reana/reana_dev/git.py 25.26% <0.00%> (ø)

Copy link
Member

@Alputer Alputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiborsimko tiborsimko merged commit 3788789 into reanahub:master Feb 5, 2025
17 checks passed
@tiborsimko tiborsimko deleted the release-chores branch February 5, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants