Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Dub/Sub selection for MovieLoadResponse #1545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JustRelaxable
Copy link
Contributor

This is not meant to be merged. Please check the related issue.

This is not meant to be merged. Please check the related issue.
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a good idea, I do not think this is the correct implementation. I understand that the current system might not have true multilingual support. However that could be taken care of on an extension level, by creating 2 extensions or adding settings to the extensions. The only reason why anime has dub/sub/raw is because that medium of media often has this reflected on the sites themself, while movie sites tend to be monolingual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants