Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap rewatch with rescript #16

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Swap rewatch with rescript #16

merged 2 commits into from
Nov 21, 2024

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Nov 20, 2024

@nojaf nojaf force-pushed the use-rescript-instead-of-rewatch branch from 783257c to 6f3ccac Compare November 21, 2024 10:52
@nojaf
Copy link
Collaborator Author

nojaf commented Nov 21, 2024

Man, this is a tradeoff. The alternative is that the tests aren't running when using rewatch.
That is not good either.

@nojaf nojaf merged commit e5386f8 into main Nov 21, 2024
2 checks passed
@fhammerschmidt
Copy link
Member

An alternative would be to have a separate npm workspace for the tests. Then you can get rid of "type": "dev" and it should work.

@nojaf
Copy link
Collaborator Author

nojaf commented Nov 21, 2024

Thanks, didn't thought of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojaf @fhammerschmidt