Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap rewatch with rescript #16

Merged
merged 2 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ jobs:
- name: Install dependencies
run: npm ci

# There is a bug in the ReScript compiler where it tries to compile the test files before finishing the source files
- name: Build ReScript code
run: npm run build
continue-on-error: true

- name: Rebuild ReScript code
run: npm run build

- name: Run tests
run: npm test
Expand Down
7 changes: 6 additions & 1 deletion docs/content/docs/contributing/getting-started.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,13 @@ This will update your fork with the latest from `rescript-lang/experimental-resc

## Initial build

Install the dependencies and compile the bindings using [Rewatch](https://github.com/rescript-lang/rewatch):
Install the dependencies and compile the bindings using `ReScript`:

```shell
npm install && npm run build
```

<Aside type="caution">
Usage of **[rewatch](https://github.com/rescript-lang/rewatch)** is currently not advised.
See [rewatch#144](https://github.com/rescript-lang/rewatch/issues/144) and [rewatch#124](https://github.com/rescript-lang/rewatch/issues/124#issuecomment-2488194551)
</Aside>
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"type": "module",
"scripts": {
"test": "node tests/index.js",
"build": "rewatch",
"format": "rescript format -all && prettier --write ./tests/index.js ./package.json",
"build": "rescript",
"format": "rescript format -all && prettier --write ./docs ./tests/index.js ./package.json",
"docs": "astro dev",
"build:docs": "astro build"
},
Expand Down
4 changes: 2 additions & 2 deletions src/CSSFontLoadingAPI/FontFaceSet.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/CanvasAPI/OffscreenCanvas.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/ChannelMessagingAPI/MessagePort.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/ClipboardAPI/Clipboard.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/Animation.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/DOMAPI/CharacterData.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/Comment.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/Document.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/DOMAPI/DocumentFragment.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/DOMAPI/Element.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/DOMAPI/FillStyle.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLAnchorElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLAreaElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLAudioElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLBRElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLBaseElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLBodyElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLButtonElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLCanvasElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLDListElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLDataElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLDataListElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLDialogElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLDivElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/DOMAPI/HTMLElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLEmbedElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLFieldSetElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLFormElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLFrameSetElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLHRElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLHeadElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/DOMAPI/HTMLHeadingElement.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading