Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NodeSvcHandle into core networking #2817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move NodeSvcHandle into core networking #2817

wants to merge 1 commit into from

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Mar 3, 2025

Copy link

github-actions bot commented Mar 3, 2025

Test Results

  7 files  ± 0    7 suites  ±0   5m 2s ⏱️ + 2m 24s
 54 tests + 9   53 ✅ + 9  1 💤 ±0  0 ❌ ±0 
223 runs  +49  220 ✅ +49  3 💤 ±0  0 ❌ ±0 

Results for commit c721b65. ± Comparison against base commit b16d7da.

This pull request removes 10 and adds 19 tests. Note that renamed tests count towards both.
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[1]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[2]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[3]
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeVirtualObject(URL, Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInCounterService(URL, int, Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInEventHandler(URL, int, Client)
dev.restate.sdktesting.tests.KillInvocation ‑ kill(Client, URL)
dev.restate.sdktesting.tests.PrivateService ‑ privateService(URL, Client)
dev.restate.sdktesting.tests.UpgradeWithInFlightInvocation ‑ inFlightInvocation(Client, URL)
dev.restate.sdktesting.tests.UpgradeWithNewInvocation ‑ executesNewInvocationWithLatestServiceRevisions(Client, URL)
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client, URI)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client, URI)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancel(BlockingOperation, Client, URI)[3]
dev.restate.sdktesting.tests.Combinators ‑ awakeableOrTimeoutUsingAwaitAny(Client)
dev.restate.sdktesting.tests.Combinators ‑ awakeableOrTimeoutUsingAwakeableTimeoutCommand(Client)
dev.restate.sdktesting.tests.Combinators ‑ firstSuccessfulCompletedAwakeable(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeVirtualObject(URI, Client)
…

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman marked this pull request as ready for review March 3, 2025 13:44
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants