-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install metrics recorder as early as possible #2818
Open
AhmedSoliman
wants to merge
2
commits into
main
Choose a base branch
from
pr2818
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+325
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 7 files ± 0 7 suites ±0 4m 41s ⏱️ + 2m 3s Results for commit d1a7e71. ± Comparison against base commit b16d7da. This pull request removes 10 and adds 19 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
jackkleeman
approved these changes
Mar 3, 2025
tillrohrmann
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 for merging.
This PR moves prometheus metrics installation to happen before starting task-center. This allows metrics and definitions to be recorded before network server is started ``` // intentionally empty ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves prometheus metrics installation to happen before starting task-center. This allows metrics and definitions to be recorded before network server is started
Stack created with Sapling. Best reviewed with ReviewStack.