Vector chapter integration. #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A semicolon was missing on a not equal sign hex character.
Added Vector spec asciidoc to Ch. 22. Moved all heading levels up one. Added Vector appendices. Fixed erroneous heading levels caused by equal signs without spaces after them.
Added Vector and all supporting files.
Added square brackates and svg values. Added period character delimiters.
Added square brackets around wavedrom declaration. Added period delimiters.
Added square brackets around wavedrom declarations. Added period delimiters.
Adding in references for math symbols.
Add html refs for math symbols.
Added flost and align center and header options to all tables.
Deleted outside square bracket from Table formatting lines.
Adding table formatting to tables in wavedrom files.
For some reason these two waavedroms are inline. Fixing them so they render correctly.
Playing with table formatting.
Due to a bug in prawn-pdf I had to add cells to the table to hold the 0 and 1 in each row vs spanning 64 rows each.
Adding untracked files for vector chapter
Fixes #900 Signed-off-by: Michael Platzer <[email protected]>
Signed-off-by: Nick Knight <[email protected]>
This commit removes the word "proposed". Signed-off-by: Tsukasa OI <[email protected]>
Since it passed the public review, this commit removes references to "public review". It doesn't use the word like "ratified" since this is a working version (not exactly a ratified version). Signed-off-by: Tsukasa OI <[email protected]>
Because we share the same name space, inst-table.adoc is too generic. This commit renames inst-table.adoc to v-inst-table.adoc to make sure that this is the instruction table for vector. Signed-off-by: Tsukasa OI <[email protected]>
This reverts commit a9c934e. Because all the files are already moved under src/images/wavedrom, we don't need those files. Signed-off-by: Tsukasa OI <[email protected]>
Signed-off-by: eop Chen <[email protected]>
|
Hi folks, just wondering where review of this chapter is at? I'd like to see this chapter merged soon. |
|
Do you know who's supposed to be reviewing it? |
|
@kasanovic would you be the primary reviewer here or would you recommend someone else review inclusion of this chapter? |
|
I sohuld be primary reviewer, but have been backlogged, hopefuoly get
to in next couple of weeks,
Krste
>>>> On Fri, 25 Aug 2023 05:32:58 -0700, Bill Traynor ***@***.***> said:
| @kasanovic would you be the primary reviewer here or would you recommend someone else review inclusion of this chapter?
| —
| Reply to this email directly, view it on GitHub, or unsubscribe.
| You are receiving this because you were mentioned.*Message ID: ***@***.***>
|
|
Thanks Krsta, I'm going to go ahead and add you as the reviewer in GitHub.
…On Thu, Aug 31, 2023 at 9:01 AM Krste Asanovic ***@***.***> wrote:
I sohuld be primary reviewer, but have been backlogged, hopefuoly get
to in next couple of weeks,
Krste
>>>>> On Fri, 25 Aug 2023 05:32:58 -0700, Bill Traynor ***@***.***> said:
| @kasanovic would you be the primary reviewer here or would you recommend
someone else review inclusion of this chapter?
| —
| Reply to this email directly, view it on GitHub, or unsubscribe.
| You are receiving this because you were mentioned.*Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#1088 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN6ZGQNB5LFSQOXUO4GNDXYCDL5ANCNFSM6AAAAAA3IVTWWE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Manually applying change from Vector spec.
Manually applying a change that was made to the vector spec.
vmoya-smd
reviewed
Jan 15, 2024
|
I guess the purpose of this MR is mainly to move the v-spec content to the unprivileged ISA manual, not to review v-spec content by itself or new changes between v1.1 and v1.0 or new changes for v2.0. So I will perform a more detailed read but I don't think anything I find from that should block this merge. |
|
That's correct, Victor. I'll fix up everything you've pointed out thus far. Following that, I think further content changes can and should be made post merge. |
As suggested by Victor, this removes the link to the old Vector spec GitHub repository.
As suggested Vector Colling Convention appendix is being renamed to better indicate that it applies to Vector only.
…dix. This moves the Fractional Lmul Example into the Vector Assembly Code Examples appendix instead of a standalone appendix.
…idths. Trying to fix table rendering in PDF via table font-size and column widths. A side effect may be table breakage elsewhere in the spec.
I was able to fix the formatting for this table.
|
Hello @vmoya-smd , I've resolved (where possible) your suggested changes. I still need a solution for formatting tables with fixed width columns but I believe that shouldn't inhibit this MR. @aswaterman, @kasanovic , @jjscheel the Vector chapter is now at a point where it can be merged into the Unprivileged spec. There may be small fixes required afterward but content-wise, everything is there. |
|
Note that I will be merging Vector on Monday, March 18th and archiving the original repository. |
Incorporate two fixes to RVV 1.0 spec
|
@wmat Note that I just added a couple commits to this branch. Shouldn't need any attention from you; just FYI. |
|
Thanks!
Bill Traynor
Documentation Build and Release Engineer
RISC-V International
…On Mon, Mar 18, 2024 at 6:21 PM Andrew Waterman ***@***.***> wrote:
@wmat <https://github.com/wmat> Note that I just added a couple commits
to this branch. Shouldn't need any attention from you; just FYI.
—
Reply to this email directly, view it on GitHub
<#1088 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN6ZAHUS74RHME4IXHNGLYY5SFLAVCNFSM6AAAAAA3IVTWWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGE2DQNRSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Adding the standard Note formatting.
|
@wmat wasn't this supposed to be integrated already? |
Signed-off-by: Andrew Waterman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates Vector into riscv-isa-manual.