fail on missing snapshots #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelglass
added a commit
that referenced
this pull request
Dec 9, 2022
* include fork of rspec-snapshot that fails the build when the snapshot is written * confirm missing snapshots fail the build * Revert "confirm missing snapshots fail the build" This reverts commit b4e3dd2.
michaelglass
added a commit
that referenced
this pull request
Dec 9, 2022
* fail on missing snapshots (#57) * include fork of rspec-snapshot that fails the build when the snapshot is written * confirm missing snapshots fail the build * Revert "confirm missing snapshots fail the build" This reverts commit b4e3dd2. * test exit more carefully (#56) * graceful exit within abq was masking rspec tests on older versions of rspec * add an additional exit safeguard * check num tests vs expected tests * sanitize backtrace tweaks * regenerate snapshots * break test to ensure bin/check_num_tests.rb works * Revert "break test to ensure bin/check_num_tests.rb works" This reverts commit 1da32a2. * set subprocess ENV outside of the global context (#54) * use captain cli (#55) * use captain cli * unset RWX_ACCESS_TOKEN to be compatible with captain-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail the build for missing snapshots
Previously, a missing snapshot file would not fail the build.
This PR uses a fork of the snapshot gem that will fail the build when it encounters a missing snapshot.. (While I was there I fixed a separate bug).
the second commit shows tests failing with missing snapshots