Refactor: Replace onboard with Eip1193Provider in dispatch calls #3745

usame-algan · 2024-05-24T14:27:02Z

What it solves

Resolves #3744

This ports part of the changes over from #3727

How this PR fixes it

Changes all dispatch functions to receive wallet.provider instead of onboard
Some dispatch functions also receive wallet.address now which is needed for TxEvents
Moves assertWalletChain calls to the component calling the dispatch functions. This is a temporary solution until Display a Switch Network button if wallet is connected to a different chain #3743.

How to test it

All transaction flows and message flows need to be tested
Gas estimation should still work
Being prompted to switch the chain when transacting should still work

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions · 2024-05-24T14:27:14Z

Branch preview

✅ Deploy successful!

Website:
https://eip1193_provider--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://eip1193_provider--walletweb.review.5afe.dev/storybook/

tsconfig.json

github-actions · 2024-05-24T14:28:21Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-05-24T14:30:57Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`950 KB` (-33 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/apps/open`	`50.94 KB` (🟡 +30 B)	1000.94 KB
`/transactions`	`73.88 KB` (🟡 +30 B)	1023.88 KB
`/transactions/history`	`73.84 KB` (🟡 +30 B)	1023.84 KB
`/transactions/messages`	`33.87 KB` (🟡 +30 B)	983.87 KB
`/transactions/queue`	`29.11 KB` (🟡 +30 B)	979.11 KB
`/transactions/tx`	`18.86 KB` (🟡 +30 B)	968.86 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-05-24T14:33:16Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	79.47% (+0% 🔼)	11308/14229
🔴	Branches	58.44% (-0.02% 🔻)	2704/4627
🟡	Functions	66.57% (-0.1% 🔻)	1820/2734
🟢	Lines	80.85% (+0% 🔼)	10198/12613

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / helpers.ts	83.33% (-16.67% 🔻)	100%	80% (-20% 🔻)	83.33% (-16.67% 🔻)
🟡	`...` / sdk.ts	68.04% (-1.75% 🔻)	38.1%	61.54% (-7.69% 🔻)	66.67% (-1.94% 🔻)
🟢	`...` / useSafeMessage.ts	94.74% (-5.26% 🔻)	100%	75% (-25% 🔻)	94.44% (-5.56% 🔻)
🟡	`...` / CounterfactualForm.tsx	68.57% (-0.55% 🔻)	40% (-2.86% 🔻)	66.67%	68.66% (-0.57% 🔻)
🟢	`...` / ReviewSignMessageOnChain.tsx	86.11% (-0.65% 🔻)	61.9% (-3.1% 🔻)	83.33%	86.76% (-0.74% 🔻)
🔴	`...` / recovery-sender.ts	13.21% (-1.34% 🔻)	0%	0%	13.21% (-1.34% 🔻)

Test suite run success

1437 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 0aa42f8

src/services/tx/tx-sender/sdk.ts

schmanu · 2024-05-27T07:59:28Z

src/services/tx/tx-sender/sdk.ts

-  const signer = await getAssertedChainSigner(onboard, chainId)
+export const getUncheckedSafeSDK = async (provider: Eip1193Provider): Promise<Safe> => {
+  const browserProvider = createWeb3(provider)
+  const signer = await browserProvider.getSigner()


If we update to the latest protocol-kit it actually expects EIP 1193 Providers and removes all adapters.
Should we use the opportunity to do this in this PR?

https://docs.safe.global/sdk/protocol-kit/reference/migrate-to-v4

Thats really nice! Doesn't look like too big of a change but just to be safe I would do the migration in a follow-up PR after this is merged.

Added an issue: #3750

github-actions · 2024-05-29T11:54:57Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

liliya-soroka · 2024-05-30T09:47:53Z

Switch network doesn't work for rabby wallet. On prod we are showing the error with information about wrong chain in the wallet. In the PR there is no such error.
@usame-algan

usame-algan · 2024-05-30T11:43:07Z

Switch network doesn't work for rabby wallet. On prod we are showing the error with information about wrong chain in the wallet. In the PR there is no such error. @usame-algan

Thanks for reporting! I can reproduce that the error notification is not visible anymore. I found a way however to fix this error for adding networks in Rabby so I will create a separate PR to dev instead of only fixing the notification. Created a PR here: #3776

github-actions · 2024-05-31T07:52:12Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

fix: Replace onboard with Eip1193Provider in dispatch calls

8cf69f6

usame-algan requested a review from schmanu May 24, 2024 14:27

usame-algan commented May 24, 2024

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

katspaugh approved these changes May 27, 2024

View reviewed changes

katspaugh changed the title ~~fix: Replace onboard with Eip1193Provider in dispatch calls~~ Refactor: Replace onboard with Eip1193Provider in dispatch calls May 27, 2024

schmanu reviewed May 27, 2024

View reviewed changes

usame-algan added 2 commits May 27, 2024 10:10

fix: Remove dangling console.log

c401f80

Merge remote-tracking branch 'origin/dev' into eip1193-provider

54042d9

usame-algan mentioned this pull request May 30, 2024

fix: Add network to Rabby if unknown #3776

Merged

3 tasks

Merge remote-tracking branch 'origin/dev' into eip1193-provider

4a34e9d

Merge remote-tracking branch 'origin/dev' into eip1193-provider

0aa42f8

katspaugh merged commit 0e20e87 into dev Jun 3, 2024
14 checks passed

katspaugh deleted the eip1193-provider branch June 3, 2024 16:35

github-actions bot locked and limited conversation to collaborators Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: Replace onboard with Eip1193Provider in dispatch calls #3745

Refactor: Replace onboard with Eip1193Provider in dispatch calls #3745

usame-algan commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

schmanu May 27, 2024

usame-algan May 27, 2024

usame-algan May 27, 2024

github-actions bot commented May 29, 2024

liliya-soroka commented May 30, 2024 •

edited

Loading

usame-algan commented May 30, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

Refactor: Replace onboard with Eip1193Provider in dispatch calls #3745

Refactor: Replace onboard with Eip1193Provider in dispatch calls #3745

Conversation

usame-algan commented May 24, 2024 • edited Loading

What it solves

How this PR fixes it

How to test it

Checklist

github-actions bot commented May 24, 2024 • edited Loading

Branch preview

github-actions bot commented May 24, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented May 24, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

🎉 Global Bundle Size Decreased

Six Pages Changed Size

github-actions bot commented May 24, 2024 • edited Loading

Coverage report

Test suite run success

schmanu May 27, 2024

Choose a reason for hiding this comment

usame-algan May 27, 2024

Choose a reason for hiding this comment

usame-algan May 27, 2024

Choose a reason for hiding this comment

github-actions bot commented May 29, 2024

ESLint Summary View Full Report

liliya-soroka commented May 30, 2024 • edited Loading

usame-algan commented May 30, 2024 • edited Loading

github-actions bot commented May 31, 2024 • edited Loading

ESLint Summary View Full Report

usame-algan commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

github-actions bot commented May 24, 2024 •

edited

Loading

liliya-soroka commented May 30, 2024 •

edited

Loading

usame-algan commented May 30, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading