fix: Add network to Rabby if unknown #3776
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
The second commit is still the lint issues that happen to me whenever I try to push something. Would be nice if we could get this merged to dev soon because I've added these lint fixes probably 5 times now in different PRs 😪 |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
950.02 KB (🟡 +46 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/balances |
29.24 KB (🟡 +6 B) |
979.26 KB |
/home |
57.41 KB (🟡 +3 B) |
1007.43 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1436 tests passing in 197 suites. Report generated by 🧪jest coverage report action from 15a1b54 |
| @@ -21,7 +21,7 @@ const useOnrampAppUrl = (): string | undefined => { | |||
|
|
|||
| const useBuyCryptoHref = (): LinkProps['href'] | undefined => { | |||
| const query = useSearchParams() | |||
| const safe = query.get('safe') | |||
| const safe = query?.get('safe') | |||
There was a problem hiding this comment.
You seem to fix these randomly in various PRs. Is it really required? Can we fix all of them in one separate PR?
There was a problem hiding this comment.
Whenever I run git push I get this and it causes the same lint errors. I am fixing all of them in each of my PRs and its always the same ones so once we have this merged to dev it should be resolved.
| const errorCode = get(error, 'code') as number | undefined | ||
|
|
||
| // Rabby emits the same error code as MM, but it is nested | ||
| const nestedErrorCode = get(error, 'data.originalError.code') as number | undefined |
There was a problem hiding this comment.
Is this better than data?.originalError?.code?
There was a problem hiding this comment.
I think it is definitely more readable. As an alternative I tried to check for each key before accessing it i.e.'data' in error && 'originalError' in (error.data as ...) && error.data.originalError but it got messy really fast. We could ofc also go with data?.originalError?.code and ts-ignore it.
What it solves
Part of #3745
How this PR fixes it
In Rabby, the error when trying to switch to a network that is not yet added is nested and doesn't pass our condition. It now checks for a nested
codein the error that is thrown.How to test it
Screenshots
Checklist