Video plugin #694
Open
Video plugin #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmedix
reviewed
Apr 16, 2018
src/lib/defaultOptions.js
Outdated
| * | ||
| * @type {string} | ||
| */ | ||
| facebookParameters: 'width="560" height="315"' + |
There was a problem hiding this comment.
Missing space at the end of the string
Closed
|
Does this depend on a different PR? |
|
OK, got it. Wrong interpretation |
brunoais
reviewed
Apr 17, 2018
| div = document.createElement('div'); | ||
| label = document.createElement('label'); | ||
| label.setAttribute('for', 'link'); | ||
| label.textContent = editor._('Video URL:'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #686 and #687
The plugin removes youtube command and adds a new "video" command that will recognize which video tag should be used based on the provided URL.
Current implementation includes YouTube and Facebook videos processing.
Youtube bbcode formater is used from the based code, which is based on the #687 PR in order to use the configuration parameters. I could move it to the plugin as well if you decide to move the youtube logic out of the base code.
Material and Monocons youtube icon is used as movie icon. Famfamfam new icon was added.
Movie icon is placed after the picture icon, which makes more sense than current youtube button location.