Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always convert attribute values to String #11

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Always convert attribute values to String #11

merged 2 commits into from
Jun 20, 2024

Conversation

sbsoftware
Copy link
Owner

Fixes #10

Benchmark:

         ecr   1.40M (714.96ns) (± 3.21%)  4.25kB/op          fastest
     to_html 822.98k (  1.22µs) (± 1.03%)   5.5kB/op     1.70× slower
html_builder  58.64k ( 17.05µs) (± 0.82%)  10.4kB/op    23.85× slower
       water  58.64k ( 17.05µs) (± 1.67%)  11.2kB/op    23.85× slower
   blueprint   1.00k (996.28µs) (±18.82%)  9.13MB/op  1393.48× slower

@sbsoftware sbsoftware merged commit 62d90ee into main Jun 20, 2024
1 check passed
@sbsoftware sbsoftware deleted the feature/HTML-36 branch June 20, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute values aren't automatically #to_sed anymore
1 participant
@sbsoftware