Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for layer selection in get_values() method #818

Merged
merged 8 commits into from
Jan 5, 2025

Conversation

Sonja-Stockhaus
Copy link
Collaborator

We need the method in spatialdata-plot and I'm currently adding the possibility to color shapes/points/labels by values stored in a different layer of a table (scverse/spatialdata-plot#326). For that, we would need this functionality here as well.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.78%. Comparing base (2865dfd) to head (60193de).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata/_core/query/relational_query.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
- Coverage   91.79%   91.78%   -0.01%     
==========================================
  Files          45       45              
  Lines        7120     7124       +4     
==========================================
+ Hits         6536     6539       +3     
- Misses        584      585       +1     
Files with missing lines Coverage Δ
src/spatialdata/_core/spatialdata.py 90.78% <ø> (ø)
src/spatialdata/_core/query/relational_query.py 90.51% <80.00%> (-0.15%) ⬇️

@LucaMarconato
Copy link
Member

Looks great thanks! I added a small test, now auto-merging.

@LucaMarconato LucaMarconato enabled auto-merge (squash) January 5, 2025 17:22
@LucaMarconato LucaMarconato merged commit 30f8103 into main Jan 5, 2025
8 checks passed
@LucaMarconato LucaMarconato deleted the feature/get_values_takes_table_layer branch January 5, 2025 17:35
@LucaMarconato LucaMarconato changed the title add support for layer selection of get_values method add support for layer selection in get_values() method Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants