Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(azure-artifact): support public address in cql_ip_address #6062

Merged
merged 1 commit into from
Apr 23, 2023
Merged

fix(azure-artifact): support public address in cql_ip_address #6062

merged 1 commit into from
Apr 23, 2023

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Apr 23, 2023 •
edited
Loading

since 506c0bd azure artifacts are working with public address, but some of SCT around connecting to CQL isn't supporting correctly the public option.

Testing

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

@fruch fruch added the backport/none Backport is not required label Apr 23, 2023
@fruch fruch requested review from soyacz and fgelcer April 23, 2023 20:06
@fruch fruch added test-provision-aws Run provision test on AWS test-provision-azure labels Apr 23, 2023
@fruch
fix(azure-artifact): support public address in cql_ip_address
83459e1 
since 506c0bd azure artifacts
are working with public address, but some of SCT around connecting
to CQL isn't supporting correctly the public option.
@fruch fruch force-pushed the fix_azure_arifact_test branch from 08ed955 to 83459e1 Compare April 23, 2023 20:08
@fruch fruch mentioned this pull request Apr 23, 2023
Closed
2 tasks
fgelcer
fgelcer approved these changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@fgelcer fgelcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 0db057d into scylladb:master Apr 23, 2023
@yaronkaikov
Copy link
Contributor

@fruch @fgelcer Problem is still not solved. https://jenkins.scylladb.com/job/scylla-master/job/artifacts/job/artifacts-azure-image-test/233/

@fruch
Copy link
Contributor Author

fruch commented Apr 24, 2023

@fruch @fgelcer Problem is still not solved. https://jenkins.scylladb.com/job/scylla-master/job/artifacts/job/artifacts-azure-image-test/233/

yes seems like different issue with cqlsh
scylladb/scylla-cqlsh#32

I'll check if reverting the usage of public address address the issue, or just extend the timeout for those commands

anyhow this is not a showstopper for the azure image itself.

@yaronkaikov
Copy link
Contributor

It's preventing us from promoting next machine image, so I can backport the kernel fix to 5.2 which is a showstopper

@fruch
Copy link
Contributor Author

fruch commented Apr 24, 2023

It's preventing us from promoting next machine image, so I can backport the kernel fix to 5.2 which is a showstopper

reverting the change
#6062

@fruch fruch added backport/5.2 Need backport to 5.2 backport/2023.1 Need to backport to 2023.1 backport/2023.1-done Commit backported to 2023.1 backport/5.2-done Commit backported to 5.2 and removed backport/none Backport is not required labels Apr 25, 2023
@enaydanov enaydanov mentioned this pull request Jul 18, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgelcer fgelcer fgelcer approved these changes

@soyacz soyacz Awaiting requested review from soyacz

Assignees

@fruch fruch

Labels
backport/5.2-done Commit backported to 5.2 backport/5.2 Need backport to 5.2 backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1 test-provision-aws Run provision test on AWS test-provision-azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruch @yaronkaikov @fgelcer