Implement the timeout for WASM client #1274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seanmonstar ping~ Could u pls review this PR? |
|
@seanmonstar Can this be reviewed and merged please ? This seem to be super useful to have and I am in need of this timeout functionality in wasm build mode where I am making fan-out calls to multiple api's and the page kind of blocked for a while even if one of the endpoint is down. |
|
@seanmonstar Can you please review this? This is really useful. |
flisky
added a commit
to flisky/reqwest
that referenced
this pull request
Feb 24, 2023
flisky
added a commit
to flisky/reqwest
that referenced
this pull request
Apr 8, 2023
|
What's the status of this PR? And if it doesn't get merged documentation on how to accomplish a timeout in WebAssembly instead would be very useful :) |
Signed-off-by: Eduard Kyvenko <[email protected]>
halfzebra
force-pushed
the
wasm-timeout
branch
from
2886628 to
380eeec
Compare
|
The |
jakubadamw
pushed a commit
to grafbase/reqwest
that referenced
this pull request
May 1, 2024
jakubadamw
pushed a commit
to grafbase/reqwest
that referenced
this pull request
Jun 11, 2024
jakubadamw
pushed a commit
to grafbase/reqwest
that referenced
this pull request
Jul 30, 2024
pimeys
pushed a commit
to grafbase/reqwest
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello friends! 🙌
This PR aims to close #1135
Feedback is very welcome and I will address any comments asap.
Let me know what you think!