feat(wasm): support request timeout #1760
Merged
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Feb 24, 2023
|
I've replace (For the potential question: why not use |
|
is there a plan to merge this please? |
|
Hi any news about this one? To know if it's planned to add it or not? |
|
I don't usually bump threads, but curious what is the holdup on this one? 😄 Seems like an easy win |
|
So sorry this slipped, yes this seems much simpler. Happy to add it! It seems like there's a test failure in WASM, though. Related? |
|
It turns out that error message keywords didn't match, @seanmonstar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for PR #1755, making wasm timeout support is super easy now.
fixes #1135 supersede #1274