Feat cm edit goal #272

KCCPMG · 2023-12-01T02:43:16Z

Update Iep and Goal components to bring them closer to relevant figma designs, create [goal_id] page to enable goal edits, create backend procedure for editing goals on iep router.

Possible issues to create after merge:
-Build Add Benchmark page (also Edit Benchmark page?)
-Standardize/Transfer to CSS styling for Add Benchmark link
-Correct Goal component alignment with design, including toast notifications
-Correct Iep component alignment with design, including toast notifications
-Build out rest of [goal_id] page to align with design (rendering subgoals)

…ss to include type

…le, re-run type-css

…component within Goal component

…ming form, change Goal mapping in Iep component to List and ListItem from ul and List

…ntainer

…form working

…n.default, button.secondary

…oal_id] and .mainGoal to Layout component

…b component

…ror handler on [goal_id] for editGoal mutation

…parent stack to 1200px to match MUI containers

…to indicate link

… to match main, tests passing

tessathornberry

Please look over all of the whiteboxed system-created comments as well you can see them on the changes page.

src/backend/routers/iep.ts

src/backend/routers/iep.test.ts

src/components/goal/Goal.tsx

src/pages/goals/[goal_id].tsx

src/styles/GoalPage.module.css

codetheweb

the size of this makes it a bit difficult to review, would it be possible to split this up into a few separate PRs? maybe one for the design updates and one for the goal edit page?

KCCPMG · 2023-12-12T15:38:26Z

the size of this makes it a bit difficult to review, would it be possible to split this up into a few separate PRs? maybe one for the design updates and one for the goal edit page?

Honestly I'm not sure how I would go about doing that at this point. Is there an easy way to do that, especially one that would preserve the comments that Tessa already made?

tessathornberry · 2023-12-12T22:03:27Z

the size of this makes it a bit difficult to review, would it be possible to split this up into a few separate PRs? maybe one for the design updates and one for the goal edit page?

Honestly I'm not sure how I would go about doing that at this point. Is there an easy way to do that, especially one that would preserve the comments that Tessa already made?

If it were me, I might start from the current main branch and for each of the tasks, follow the sequence of:

create a differently-named new local branch for that particular task (something like feat-goal-page, feat-goal-edit, feat-goal-edit-tests, feat-goal-css, or what you think is right)
commit code for just one task
push code up to that distinct branch and make a PR for that task
start at 1 above except with the new branch based on the code from your just-submitted PR

You can leave this PR as-is, I think! ;)
If you want to add your broken-out tasks as simple issues you refer to with each smaller PR, you can do that here and then add those by editing the main issue as tasks with checkboxes like [ ] - #taskIssueNumber

…liminate bacgkround color change on hover on rendered goals

hieungo89 · 2024-03-07T02:25:13Z

src/styles/GoalPage.module.css

@@ -0,0 +1,53 @@
+.goalDescriptionContainer {
+  background-color: #ffffff;


You can use the global-defined variable for colors instead of the color palette. All the global variables are defined in globals.css

Got it. There was one color I kept as is since there was no global variable to handle it, but the others I found and utilized.

src/styles/GoalPage.module.css

tessathornberrypadg

It looks good, Connor! Please update the CSS per our discussion

…es in styles/GoalPage.module.css

KCCPMG added 26 commits November 10, 2023 07:49

initial commit, reconcile goalTab css with figma

35a218b

add goal class to components/goal.module.css to implement, run type-c…

5c16297

…ss to include type

refactor components/goal/Goal to match figma, add css classes to modu…

8936b5c

…le, re-run type-css

modify Add Goal button styling on Iep component, create ControlCarat …

26841c0

…component within Goal component

change Add Goal button in Iep component to handle state change for co…

6082bf1

…ming form, change Goal mapping in Iep component to List and ListItem from ul and List

modify styling and components to allow for grid, form to appear in co…

0aaae8d

…ntainer

modify ControlCarat to allow for no click handler, modify Iep to get …

6e07e1a

…form working

improve styling, replace custom button css with pre-established butto…

37ab20a

…n.default, button.secondary

add ListItem for 'Adding new goal' message, add borders to ListItems

36032a4

add basic getGoal trpc method, create start of [goal_id] page, add [g…

607c462

…oal_id] and .mainGoal to Layout component

add to [goal_id] for basic layout and styling, including SelectableTa…

229c4c2

…b component

add editing form to [goal_id]

18e4428

add editGoal mutation to trpc iep router, needs security check

e19b7e1

add auth check on trpc editGoal mutation, add basic console log on er…

c54d0fa

…ror handler on [goal_id] for editGoal mutation

clean up styling for Edit Goal button on [goal_id], set maxWidth for …

4df6a81

…parent stack to 1200px to match MUI containers

add clickthrough to goal page on [goal_id], add styling to ListItems …

5780d4b

…to indicate link

correct styling on Iep.tsx for Goals tab and Add Goal button

5671891

pre-merge update .eslintrc.json to match main, tests passing

ebdcd01

pre-merge update package.json and src/backend/texts/fixtures/mocks.ts…

56ad19d

… to match main, tests passing

correct spacing issue by fixing margin on src/components/iep/Iep

795fc00

add 'Add benchmark' link to src/components/goal/Goal.tsx

580624d

pre-merge delete of commented-out JSX for subgoal form

af1ca81

merge main into branch

3d72c70

GoalPage tab container css fix

ae2edf0

clean up commented out code before PR

eacde84

add test to iep.test.ts for editGoal procedure

fb97ebf

KCCPMG requested review from codetheweb, hieungo89 and tessathornberry December 1, 2023 02:43

rerun npm install and npm run format

c8af12a

tessathornberry requested changes Dec 7, 2023

View reviewed changes

KCCPMG added 4 commits December 8, 2023 21:15

Merge branch 'main' into feat-cm-edit-goal

9588f29

remove unused variables from edit goal test in routers.iep.test.ts

efb3b1b

remove the work 'Changes' from buttons when editing a goal

31f8e07

correct background of .editGoalFormTextArea in GoalPage.module.css

06fc99f

codetheweb reviewed Dec 12, 2023

View reviewed changes

KCCPMG added 2 commits December 13, 2023 15:41

change 'Add Benchmark' from link to button, stop event propagation, e…

1996f75

…liminate bacgkround color change on hover on rendered goals

remove ControlCarat, replace with MaterialUI forward arrow icon

57ad214

KCCPMG mentioned this pull request Feb 8, 2024

Fix cm student id page #280

Merged

KCCPMG added 2 commits February 11, 2024 14:16

merge branch 'main' into feat-cm-edit-goal

181e854

update button import in pages/goals/[goal_id]

94086e8

KCCPMG linked an issue Feb 15, 2024 that may be closed by this pull request

Make Editing Goals possible [ENG] #216

Closed

2 tasks

Merge branch 'main' into feat-cm-edit-goal

5c152c6

hieungo89 reviewed Mar 7, 2024

View reviewed changes

tessathornberrypadg reviewed Mar 7, 2024

View reviewed changes

src/styles/GoalPage.module.css Outdated Show resolved Hide resolved

hieungo89 approved these changes Mar 7, 2024

View reviewed changes

tessathornberrypadg suggested changes Mar 7, 2024

View reviewed changes

tessathornberry approved these changes Mar 7, 2024

View reviewed changes

KCCPMG mentioned this pull request Mar 7, 2024

Determine security strategy for correctly limiting data visibility and manipulation[ENG] #300

Open

correct for consistency when using 'background-color', global variabl…

76158a4

…es in styles/GoalPage.module.css

KCCPMG merged commit 6a388a0 into main Mar 7, 2024
3 checks passed

hieungo89 deleted the feat-cm-edit-goal branch March 7, 2024 23:20

KCCPMG mentioned this pull request Mar 8, 2024

Benchmark creation #298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat cm edit goal #272

Feat cm edit goal #272

KCCPMG commented Dec 1, 2023

tessathornberry left a comment

codetheweb left a comment

KCCPMG commented Dec 12, 2023

tessathornberry commented Dec 12, 2023 •

edited

Loading

hieungo89 Mar 7, 2024

KCCPMG Mar 7, 2024

tessathornberrypadg left a comment

		@@ -0,0 +1,53 @@
		.goalDescriptionContainer {
		background-color: #ffffff;

Feat cm edit goal #272

Feat cm edit goal #272

Conversation

KCCPMG commented Dec 1, 2023

tessathornberry left a comment

Choose a reason for hiding this comment

codetheweb left a comment

Choose a reason for hiding this comment

KCCPMG commented Dec 12, 2023

tessathornberry commented Dec 12, 2023 • edited Loading

hieungo89 Mar 7, 2024

Choose a reason for hiding this comment

KCCPMG Mar 7, 2024

Choose a reason for hiding this comment

tessathornberrypadg left a comment

Choose a reason for hiding this comment

tessathornberry commented Dec 12, 2023 •

edited

Loading