-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cm student id page #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pushing ArrowForwardIosIcon into Add Goal form
…gic, run prettier
5 tasks
codetheweb
approved these changes
Feb 9, 2024
hieungo89
pushed a commit
that referenced
this pull request
Feb 13, 2024
* add Goal and Iep components and css from feat-cm-edit-goal * remove css class in Goal.module.css for removed controlCarat class * add flexWrap: wrap to div containing benchmark info in goal to avoid pushing ArrowForwardIosIcon into Add Goal form * run prettier * remove additional unused code and imports from components/goal/Goal
hieungo89
added a commit
that referenced
this pull request
Feb 14, 2024
* Add user to the staff list on the frontend instead of the backend * [Closes #221] Update dependencies, resolve all npm audit warnings (#259) * Ran npm audit fix * Remove deprecated @next/font * Replace mockery with rewiremock * Bump nextjs version * Bump typed-css-modules version * Staff page (#269) Co-authored-by: Brandon Cruz-Youll <[email protected]> * Add breadcrumbs (#268) * changed placeholder to defaultValue on forms for edit student and edit staff (#276) * added placeholder files and instruction documentation for Design System components and their css modules (#275) * Update button module to override MUI styling and apply to all button instances (#277) * fix secondary button styling on button module and apply to edit button on student page * add button folder with button module to components * change imports for button module * fix edit, cancel, and save buttons on student page * replace button module file in design system button folder and delete previous button folder * replace import statements for button module * change subgoal button to inherit button module styling instead of goal module styling * change assign staff button styling in subgoal to inherit button module styling * update buttons on subgoal assignment modal to inherit button module styling * update border radius and secondary border color in button module * change all button stylings on staff page * changes to button module * prettier fix * update primary variable hex in global css file and update button color to be in accordance with DS * fix prettier in globalcss * remove sx from line 43 of staff/[user_id] and remove all instances of home.bold styling in buttons --------- * Fix cm student id page (#280) * add Goal and Iep components and css from feat-cm-edit-goal * remove css class in Goal.module.css for removed controlCarat class * add flexWrap: wrap to div containing benchmark info in goal to avoid pushing ArrowForwardIosIcon into Add Goal form * run prettier * remove additional unused code and imports from components/goal/Goal * Fix type error --------- Co-authored-by: Francis Li <[email protected]> Co-authored-by: Brett Austin Eastman <[email protected]> Co-authored-by: Brandon Cruz-Youll <[email protected]> Co-authored-by: Hieu Ngo <[email protected]> Co-authored-by: Brandon Cruz-Youll <[email protected]> Co-authored-by: Tessa Thornberry <[email protected]> Co-authored-by: Hannah McGowan <[email protected]> Co-authored-by: KCCPMG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue Update [studentId] to reflect recent Figma design [Eng]](https://github.com/orgs/sfbrigade/projects/6/views/1?pane=issue&itemId=51974915), first chunk of broken up PR #272