Replace Tailwind with Styled components #1
Conversation
jennysky
commented
Dec 8, 2022
•
jennysky
commented
- Replace tailwind with Styled components
jennysky
force-pushed
the
styled-components
branch
from
2238e73 to
c946772
Compare
| @layer components { | ||
| /* Docs styling */ | ||
| .blox-code-editor { | ||
| @apply rounded-lg mb-4 font-mono text-sm bg-gray-900 text-gray-300; |
There was a problem hiding this comment.
This what makes everything themeable , so when after you run create-blox-app you'll be able to edit the index.css for your liking.
There was a problem hiding this comment.
class blox-code-editor doesn't exists anymore,
I removed all the name classes and all the tailwind.
so I am not sure
do you want to keep empty index.css ?
There was a problem hiding this comment.
I meant that we need a way to control core components styles at docs level.
maybe with createGlobalStyle?
There was a problem hiding this comment.
added bloxStylesOverrides to createGlobalStyle, it allow to overrides all the styles in core
all the rest styles can be overrided in docs
.prettierrc
Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Adding prettier is out of scope for this PR.
I guess adding eslint is a good idea
There was a problem hiding this comment.
it was too many files , so it is hard to write without formating
I can remove it
There was a problem hiding this comment.
Please also revert prettier changes - i plan to add eslint soon + validate it on ci
There was a problem hiding this comment.
reverted prettier of the most of the unchanged files
jennysky
force-pushed
the
styled-components
branch
from
77ce332 to
5d7aa7c
Compare
