[chore] delete skipped test #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,34 +108,6 @@ def test_annotation_excluding(setup, container_name, expected): | |||
| len(events)) | |||
| assert len(events) == expected | |||
|
|
|||
| @pytest.mark.skipif(True, reason="Jira: ADDON-36296") | |||
There was a problem hiding this comment.
this ticket is closed. do we know the tests still need to be skipped?
There was a problem hiding this comment.
it was closed for inactivity.
rmfitzpatrick
approved these changes
Nov 17, 2023
|
@omrozowicz-splunk please review when you get a chance |
dmitryax
approved these changes
Nov 21, 2023
|
Merging - @omrozowicz-splunk we can discuss offline if this needs a follow-up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been skipped for a bit, prefer to delete it at this time.