Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] delete skipped test #1022

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[chore] delete skipped test #1022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions test/k8s_logging_tests/test_config_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,34 +108,6 @@ def test_annotation_excluding(setup, container_name, expected):
len(events))
assert len(events) == expected

@pytest.mark.skipif(True, reason="Jira: ADDON-36296")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ticket is closed. do we know the tests still need to be skipped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was closed for inactivity.

@pytest.mark.parametrize("test_input,expected", [
("/var/log/pods/*_kube-apiserver*", 1),
("/var/log/pods/*_ci*", 1),
("/var/log/pods/*_coredns*", 1),
("/var/log/pods/*_etcd-*", 1),
("empty_source", 0)
])
def test_source(setup, test_input, expected):
'''
Test that known sources are present in target index
'''
logger.info("testing for presence of source={0} expected={1} event(s)".format(
test_input, expected))
index_logging = os.environ["CI_INDEX_EVENTS"] if os.environ["CI_INDEX_EVENTS"] else "ci_events"
source = ' source=""' if test_input == "empty_source" else ' source=' + test_input
search_query = "index=" + index_logging + ' OR index="kube-system"' + source
events = check_events_from_splunk(start_time="-24h@h",
url=setup["splunkd_url"],
user=setup["splunk_user"],
query=["search {0}".format(
search_query)],
password=setup["splunk_password"])
logger.info("Splunk received %s events in the last minute",
len(events))
assert len(events) >= expected if test_input != "empty_source" else len(
events) == expected

@pytest.mark.parametrize("test_input,expected", [
("k8s.pod.name", 1),
("k8s.namespace.name", 1),
Expand Down