v7.0.0-beta.1 (Holesky Rescue) #7041
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid finalized epochs in sync.
…lid finalized epochs in sync.
|
|
This was referenced Feb 26, 2025
Closed
| @@ -325,7 +325,7 @@ impl<E: EthSpec> ProductionValidatorClient<E> { | |||
| get_validator_block: slot_duration / HTTP_GET_VALIDATOR_BLOCK_TIMEOUT_QUOTIENT, | |||
| } | |||
| } else { | |||
| Timeouts::set_all(slot_duration) | |||
| Timeouts::set_all(25 * slot_duration) | |||
There was a problem hiding this comment.
@macladson could you make a clean PR for a CLI flag accomplishing the same effect against the release-v7.0.0 branch? 🙏
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
Cleaned up and isolated version of the `--disable-attesting` flag for the VC, from the `holesky-rescue` branch: - #7041 I figured we don't need the `--disable-attesting` flag on the BN for now, and it was a much more invasive impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Related to #7040
Proposed Changes
Various hacks and tweaks to ensure LH syncs a valid Holesky chain.
Most notably, we explicitly reject the invalid payload that was justified (
0x2db899881ed8546476d0b92c6aa9110bea9a4cd0dbeb5519eb0ea69575f1f359).Additional Info