Added support for channel and channel_id, do not require channel. #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13217136744Details
💛 - Coveralls |
dblock
changed the title
dblock
force-pushed
the
support_channel_id_s
branch
from
3472c48 to
98e515a
Compare
dblock
force-pushed
the
support_channel_id_s
branch
from
06bf4a5 to
bf2f795
Compare
| conversations_id(channel: channel)['channel']['id'] | ||
| end.uniq.join(',') | ||
| elsif params[:channel] | ||
| complete_upload_request_params[:channel] = conversations_id( |
There was a problem hiding this comment.
should this be :channel_id instead of :channel? I don't see channel as one of the available arguments in https://api.slack.com/methods/files.completeUploadExternal
There was a problem hiding this comment.
I think you are right. I thought I did test it in https://github.com/slack-ruby/slack-ruby-client/blob/master/examples/files_upload_v2/files_upload_v2.rb#L20 but maybe I missed the fact that it wasn't posting to #general after all? Care to help fix, with a test?
There was a problem hiding this comment.
Fixed in #548, releasing as 2.5.2.
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539.
cc: @gregsaab