Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: files_upload_v2 with channel. #548

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Feb 19, 2025

Fixes files_upload_v2 with a single #channel parameter, see #540 (comment).

@dblock dblock merged commit 3f13b61 into slack-ruby:master Feb 19, 2025
12 checks passed
@coveralls
Copy link

coveralls commented Feb 19, 2025

Pull Request Test Coverage Report for Build 13415669916

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.381%

Totals Coverage Status
Change from base Build 13314730319: 0.0%
Covered Lines: 5788
Relevant Lines: 6404

💛 - Coveralls

@dblock dblock deleted the fix-channel-id branch February 19, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants